Unix Technical Forum

Re: Patch to add objetct size on "\d+" verbose output

This is a discussion on Re: Patch to add objetct size on "\d+" verbose output within the pgsql Hackers forums, part of the PostgreSQL category; --> On Sat, Apr 12, 2008 at 3:53 AM, Dickson dos Santos Guedes <guediz@gmail.com> wrote: > Well, working in the ...


Go Back   Unix Technical Forum > Database Server Software > PostgreSQL > pgsql Hackers

FAQ Members List Calendar Search Today's Posts Mark Forums Read
  #1 (permalink)  
Old 04-15-2008, 11:52 PM
Brendan Jurd
 
Posts: n/a
Default Re: Patch to add objetct size on "\d+" verbose output

On Sat, Apr 12, 2008 at 3:53 AM, Dickson dos Santos Guedes
<guediz@gmail.com> wrote:
> Well, working in the latest revision from CVS I added a feature for
> psql to the command "\d+", now it shows the object size as like as
> "\l+" show the database size.
>


I was going to try this patch out, but it would not apply. Seems that
where the patch should have &, it has &amp; instead. Has this somehow
been HTML entity-ified?

Cheers,
BJ

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Digg this Post!Add Post to del.icio.usBookmark Post in TechnoratiFurl this Post!
Reply With Quote
  #2 (permalink)  
Old 04-15-2008, 11:52 PM
Dickson dos Santos Guedes
 
Posts: n/a
Default Re: Patch to add objetct size on "\d+" verbose output

On Sat, Apr 12, 2008 at 7:43 PM, Brendan Jurd <direvus@gmail.com> wrote:
> I was going to try this patch out, but it would not apply. Seems that
> where the patch should have &, it has &amp; instead. Has this somehow
> been HTML entity-ified?


Hi Brendan,

You are right, I don't now why this occurs. I'm sending it now
gziped, You may test it again.

Thank you.
--
[]s
Dickson S. Guedes
-------------------------------------
Projeto Colmeia - Curitiba - PR
(41) 3254-7130 ramal: 27
http://makeall.wordpress.com/
http://planeta.postgresql.org.br/


--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Digg this Post!Add Post to del.icio.usBookmark Post in TechnoratiFurl this Post!
Reply With Quote
  #3 (permalink)  
Old 04-15-2008, 11:52 PM
Brendan Jurd
 
Posts: n/a
Default Re: Patch to add objetct size on "\d+" verbose output

On Mon, Apr 14, 2008 at 8:45 AM, Dickson dos Santos Guedes
<guediz@gmail.com> wrote:
> On Sat, Apr 12, 2008 at 7:43 PM, Brendan Jurd <direvus@gmail.com> wrote:
> > I was going to try this patch out, but it would not apply. Seems that
> > where the patch should have &, it has &amp; instead. Has this somehow
> > been HTML entity-ified?

>
> You are right, I don't now why this occurs. I'm sending it now
> gziped, You may test it again.
>


Hi Dickson,

I actually already corrected the '&amp;'s manually and tested your
patch like that. It's nice -- I think this is a very worthwhile
addition to \dt+

I note that your last email only went to -hackers; you might want to
send the updated version of your patch to -patches as well.

Cheers,
BJ

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Digg this Post!Add Post to del.icio.usBookmark Post in TechnoratiFurl this Post!
Reply With Quote
  #4 (permalink)  
Old 05-05-2008, 06:52 AM
Heikki Linnakangas
 
Posts: n/a
Default Re: Patch to add objetct size on "\d+" verbose output

Dickson dos Santos Guedes wrote:
> On Sat, Apr 12, 2008 at 7:43 PM, Brendan Jurd <direvus@gmail.com> wrote:
>> I was going to try this patch out, but it would not apply. Seems that
>> where the patch should have &, it has &amp; instead. Has this somehow
>> been HTML entity-ified?

>
> Hi Brendan,
>
> You are right, I don't now why this occurs. I'm sending it now
> gziped, You may test it again.


Although it would often be nice to see tables sorted by size, I don't
like having a different ordering in verbose mode, that's just confusing.

Patch committed, sans the ordering change. I also moved the Size column
before Description, I think it looks better to have the potentially long
Description column at the end. It's also consistent with the \l+ output
that way.

Thanks for the patch!

--
Heikki Linnakangas
EnterpriseDB http://www.enterprisedb.com

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Digg this Post!Add Post to del.icio.usBookmark Post in TechnoratiFurl this Post!
Reply With Quote
  #5 (permalink)  
Old 05-05-2008, 06:52 AM
Dickson dos Santos Guedes
 
Posts: n/a
Default Re: Patch to add objetct size on "\d+" verbose output

On Fri, May 2, 2008 at 7:16 AM, Heikki Linnakangas
<heikki@enterprisedb.com> wrote:
> Although it would often be nice to see tables sorted by size, I don't like
> having a different ordering in verbose mode, that's just confusing.


Yes, I agree.

> Patch committed, sans the ordering change. I also moved the Size column
> before Description, I think it looks better to have the potentially long
> Description column at the end. It's also consistent with the \l+ output that
> way.


Excelent. It is better.

> Thanks for the patch!


Thanks for your suggestions.

--
[]s
Dickson S. Guedes
-------------------------------------
Projeto Colmeia - Curitiba - PR
(41) 3254-7130 ramal: 27
http://makeall.wordpress.com/
http://planeta.postgresql.org.br/

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Digg this Post!Add Post to del.icio.usBookmark Post in TechnoratiFurl this Post!
Reply With Quote
Reply


Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

vB code is On
Smilies are On
[IMG] code is On
HTML code is Off
Trackbacks are On
Pingbacks are On
Refbacks are On
Forum Jump


All times are GMT. The time now is 11:25 PM.


Powered by vBulletin® Version 3.6.5
Copyright ©2000 - 2008, Jelsoft Enterprises Ltd.
SEO by vBSEO 3.2.0
www.UnixAdminTalk.com