vBulletin Search Engine Optimization
| |||||||
| Register | FAQ | Members List | Calendar | Search | Today's Posts | Mark Forums Read |
| ||||
| "Zeugswetter Andreas DCP SD" <ZeugswetterA@spardat.at> writes: > "If successful, _setmode returns the previous translation mode. A return > value of -1 indicates an error" > So, shouldn't we be testing for -1 instead of < 0 ? I think the usual convention is to test for < 0, unless there are other negative return values that are legal. This is doubtless a silly cycle-shaving habit (on nearly all machines, test against 0 is a bit more compact than test against other constants), but it is a widespread habit anyway, and if you sometimes do it one way and sometimes another you just create a distraction for readers. regards, tom lane ---------------------------(end of broadcast)--------------------------- TIP 2: Don't 'kill -9' the postmaster |