Unix Technical Forum

Re: [PATCHES] c.h is the problem of msvc.

This is a discussion on Re: [PATCHES] c.h is the problem of msvc. within the pgsql Hackers forums, part of the PostgreSQL category; --> "Hiroshi Saito" <z-saito@guitar.ocn.ne.jp> writes: > --- src/include/c.h.orig Sat Jul 15 01:38:59 2006 > +++ src/include/c.h Sat Jul 15 01:40:04 ...


Go Back   Unix Technical Forum > Database Server Software > PostgreSQL > pgsql Hackers

FAQ Members List Calendar Search Today's Posts Mark Forums Read
  #1 (permalink)  
Old 04-12-2008, 04:28 AM
Tom Lane
 
Posts: n/a
Default Re: [PATCHES] c.h is the problem of msvc.

"Hiroshi Saito" <z-saito@guitar.ocn.ne.jp> writes:
> --- src/include/c.h.orig Sat Jul 15 01:38:59 2006
> +++ src/include/c.h Sat Jul 15 01:40:04 2006
> @@ -60,7 +60,9 @@
> #if defined(_MSC_VER) || defined(__BORLANDC__)
> #define WIN32_ONLY_COMPILER
> #define errcode __vc_errcode
> +#if (_MSC_VER > 1400)
> #include <crtdefs.h>
> +#endif
> #undef errcode
> #endif
>


This patch certainly looks like it will break the __BORLANDC__ build ...

regards, tom lane

---------------------------(end of broadcast)---------------------------
TIP 1: if posting/reading through Usenet, please send an appropriate
subscribe-nomail command to majordomo@postgresql.org so that your
message can get through to the mailing list cleanly

Digg this Post!Add Post to del.icio.usBookmark Post in TechnoratiFurl this Post!
Reply With Quote
  #2 (permalink)  
Old 04-12-2008, 04:28 AM
Hiroshi Saito
 
Posts: n/a
Default Re: [PATCHES] c.h is the problem of msvc.

Ooops,
I am uncertain at the reason for not knowing __BORLANDC__...
It will be sure if __BORLANDC__ has the definition.
Thanks.

Regards,
Hiroshi Saito

From: "Tom Lane"


> "Hiroshi Saito" <z-saito@guitar.ocn.ne.jp> writes:
>> --- src/include/c.h.orig Sat Jul 15 01:38:59 2006
>> +++ src/include/c.h Sat Jul 15 01:40:04 2006
>> @@ -60,7 +60,9 @@
>> #if defined(_MSC_VER) || defined(__BORLANDC__)
>> #define WIN32_ONLY_COMPILER
>> #define errcode __vc_errcode
>> +#if (_MSC_VER > 1400)
>> #include <crtdefs.h>
>> +#endif
>> #undef errcode
>> #endif
>>

>
> This patch certainly looks like it will break the __BORLANDC__ build ...
>
> regards, tom lane


---------------------------(end of broadcast)---------------------------
TIP 2: Don't 'kill -9' the postmaster

Digg this Post!Add Post to del.icio.usBookmark Post in TechnoratiFurl this Post!
Reply With Quote
  #3 (permalink)  
Old 04-12-2008, 04:46 AM
Bruce Momjian
 
Posts: n/a
Default Re: [PATCHES] c.h is the problem of msvc.


Patch applied. Thanks.

---------------------------------------------------------------------------


Hiroshi Saito wrote:
> Ooops,
> I am uncertain at the reason for not knowing __BORLANDC__...
> It will be sure if __BORLANDC__ has the definition.
> Thanks.
>
> Regards,
> Hiroshi Saito
>
> From: "Tom Lane"
>
>
> > "Hiroshi Saito" <z-saito@guitar.ocn.ne.jp> writes:
> >> --- src/include/c.h.orig Sat Jul 15 01:38:59 2006
> >> +++ src/include/c.h Sat Jul 15 01:40:04 2006
> >> @@ -60,7 +60,9 @@
> >> #if defined(_MSC_VER) || defined(__BORLANDC__)
> >> #define WIN32_ONLY_COMPILER
> >> #define errcode __vc_errcode
> >> +#if (_MSC_VER > 1400)
> >> #include <crtdefs.h>
> >> +#endif
> >> #undef errcode
> >> #endif
> >>

> >
> > This patch certainly looks like it will break the __BORLANDC__ build ...
> >
> > regards, tom lane


[ Attachment, skipping... ]

>
> ---------------------------(end of broadcast)---------------------------
> TIP 2: Don't 'kill -9' the postmaster


--
Bruce Momjian bruce@momjian.us
EnterpriseDB http://www.enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

---------------------------(end of broadcast)---------------------------
TIP 9: In versions below 8.0, the planner will ignore your desire to
choose an index scan if your joining column's datatypes do not
match

Digg this Post!Add Post to del.icio.usBookmark Post in TechnoratiFurl this Post!
Reply With Quote
  #4 (permalink)  
Old 04-12-2008, 04:46 AM
Bruce Momjian
 
Posts: n/a
Default Re: [PATCHES] c.h is the problem of msvc.


Clarification, the attached version with the BORLAND adjustment is the
one that was applied.

---------------------------------------------------------------------------

Bruce Momjian wrote:
>
> Patch applied. Thanks.
>
> ---------------------------------------------------------------------------
>
>
> Hiroshi Saito wrote:
> > Ooops,
> > I am uncertain at the reason for not knowing __BORLANDC__...
> > It will be sure if __BORLANDC__ has the definition.
> > Thanks.


--
Bruce Momjian bruce@momjian.us
EnterpriseDB http://www.enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

--- src/include/c.h.orig Sat Jul 15 01:38:59 2006
+++ src/include/c.h Sat Jul 15 01:40:04 2006
@@ -60,7 +60,9 @@
#if defined(_MSC_VER) || defined(__BORLANDC__)
#define WIN32_ONLY_COMPILER
#define errcode __vc_errcode
+#if defined(__BORLANDC__) || (_MSC_VER > 1400)
#include <crtdefs.h>
+#endif
#undef errcode
#endif



---------------------------(end of broadcast)---------------------------
TIP 9: In versions below 8.0, the planner will ignore your desire to
choose an index scan if your joining column's datatypes do not
match

Digg this Post!Add Post to del.icio.usBookmark Post in TechnoratiFurl this Post!
Reply With Quote
Reply


Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

vB code is On
Smilies are On
[IMG] code is On
HTML code is Off
Trackbacks are On
Pingbacks are On
Refbacks are On
Forum Jump


All times are GMT. The time now is 11:36 PM.


Powered by vBulletin® Version 3.6.5
Copyright ©2000 - 2008, Jelsoft Enterprises Ltd.
SEO by vBSEO 3.2.0
www.UnixAdminTalk.com