Re: [PATCHES] Linking on AIX (Was: Fix linking of OpenLDAP libraries )

#1 (**permalink**) 04-12-2008, 04:47 AM

Tom Lane wrote:
> The proposed patch to Makefile.shlib makes me gag :-( ...

It is ugly.

> lying to make
> about what's the purpose of a rule is seldom a good idea. Please try
> as attached instead.

I will ASAP.

> Also, I am *really* dubious about the change to
> ecpg/test/Makefile.regress --- if that's necessary then this whole
> exercise is wrong.

For a dynamic build you do not need the change.
Only a --disable-shared build will gag without it. I'll have a look
at that too.

Yours,
Laurenz Albe

---------------------------(end of broadcast)---------------------------
TIP 2: Don't 'kill -9' the postmaster

#2 (**permalink**) 04-12-2008, 04:47 AM

"Albe Laurenz" <all@adv.magwien.gv.at> writes:
> Tom Lane wrote:
>> Also, I am *really* dubious about the change to
>> ecpg/test/Makefile.regress --- if that's necessary then this whole
>> exercise is wrong.

> For a dynamic build you do not need the change.
> Only a --disable-shared build will gag without it.

Ah. In that case I think the answer is that that makefile should be
using $(libpq) or possibly $(libpq_pgport) from Makefile.global,
rather than bare "-lpq".

regards, tom lane

---------------------------(end of broadcast)---------------------------
TIP 5: don't forget to increase your free space map settings

Thread Tools
Show Printable Version Email this Page
Display Modes
Linear Mode Switch to Hybrid Mode Switch to Threaded Mode