Unix Technical Forum

Re: pg_dump -Ft failed on Windows XP

This is a discussion on Re: pg_dump -Ft failed on Windows XP within the pgsql Hackers forums, part of the PostgreSQL category; --> > > I have repeated the problem with CVS head on XP SP2. It > *does* create > > ...


Go Back   Unix Technical Forum > Database Server Software > PostgreSQL > pgsql Hackers

FAQ Members List Calendar Search Today's Posts Mark Forums Read
  #1 (permalink)  
Old 04-12-2008, 03:04 AM
Magnus Hagander
 
Posts: n/a
Default Re: pg_dump -Ft failed on Windows XP

> > I have repeated the problem with CVS head on XP SP2. It
> *does* create
> > it there (or rather, it tries to).

>
> > tmpnam() returns a file in the current dir per documentation, but I
> > see it generating one in the root instead.
> > tempnam() uses TMP environment variable.

>
> > tmpfile() and tmpnam() both use the same function to generate the
> > filename.

>
> Hm. I guess I concur with Peter's conclusion: the cleanest
> fix is to put our own implementation of tmpfile() into src/port/.


Ok. Should be easy enough once the code is fine - can you comment on the
patch as sent, if the code itself looks right provided i wrap it up in a
function in port/?

//Magnus

---------------------------(end of broadcast)---------------------------
TIP 3: Have you checked our extensive FAQ?

http://www.postgresql.org/docs/faq

Digg this Post!Add Post to del.icio.usBookmark Post in TechnoratiFurl this Post!
Reply With Quote
  #2 (permalink)  
Old 04-12-2008, 03:05 AM
Tom Lane
 
Posts: n/a
Default Re: pg_dump -Ft failed on Windows XP

"Magnus Hagander" <mha@sollentuna.net> writes:
> Ok. Should be easy enough once the code is fine - can you comment on the
> patch as sent, if the code itself looks right provided i wrap it up in a
> function in port/?


Not sure if the error handling is adequate --- are there any cases
besides EEXIST that should loop?

A look at
http://msdn.microsoft.com/library/de..._wtmpna m.asp

suggests that tempnam() is also pretty fragile, esp. if you're passing
NULLs. Apparently it won't work at all if TMP isn't set?

regards, tom lane

---------------------------(end of broadcast)---------------------------
TIP 2: Don't 'kill -9' the postmaster

Digg this Post!Add Post to del.icio.usBookmark Post in TechnoratiFurl this Post!
Reply With Quote
Reply


Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

vB code is On
Smilies are On
[IMG] code is On
HTML code is Off
Trackbacks are On
Pingbacks are On
Refbacks are On
Forum Jump


All times are GMT. The time now is 07:09 PM.


Powered by vBulletin® Version 3.6.5
Copyright ©2000 - 2008, Jelsoft Enterprises Ltd.
SEO by vBSEO 3.2.0
www.UnixAdminTalk.com