SEO

Stefan Kaltenbrunner wrote:

[ Discussion about making infrastructure downtime more visible to people.]

> > Right now, when email is down, I just start IM'ing people. A more
> > structured system would help me.
>
> Some people would say a more structured approach to patch/bug tracking
> would help them (but maybe not help you) ;-)

[ Email moved to hackers.]

This is an interesting observation that deserves to be discussed
separately, and relates to the patch queue. Many people want to know
what is happening with the patch queue but having better reporting
doesn't seem to help much the people who are actually processing the
queue, and requires more work.

--
Bruce Momjian <bruce@momjian.us> http://momjian.us
EnterpriseDB http://postgres.enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

-
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Bruce Momjian wrote:

> This is an interesting observation that deserves to be discussed
> separately, and relates to the patch queue. Many people want to know
> what is happening with the patch queue but having better reporting
> doesn't seem to help much the people who are actually processing the
> queue, and requires more work.

I'm not sure I follow. I tried last week to give some hours for patch
review. What actually happened was that I had to wade through a ton of
stuff, skipping patches that were already applied, threads that were
purely discussion but not patches, threads about earlier versions of
some patches.

I did manage to find actual patches, but I had then to resort to my own
mailbox to get the actual patch to apply and review.

Now I can't be sure whether the current commitfest is finished or there
are still patches pending review; what patches could use input from me;
what patches I could bounce to the next commitfest.

Also I don't know what patches we have for the next commitfest. I would
gladly give some time to put up a Wiki page to list the patches for the
next commitfest. Would that be helpful?

--
Alvaro Herrera http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.

-
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Alvaro Herrera wrote:
> Bruce Momjian wrote:
>
> > This is an interesting observation that deserves to be discussed
> > separately, and relates to the patch queue. Many people want to know
> > what is happening with the patch queue but having better reporting
> > doesn't seem to help much the people who are actually processing the
> > queue, and requires more work.
>
> I'm not sure I follow. I tried last week to give some hours for patch
> review. What actually happened was that I had to wade through a ton of
> stuff, skipping patches that were already applied, threads that were
> purely discussion but not patches, threads about earlier versions of
> some patches.

Yep, that describes the painful process well.

I have tried to stay on top of patches already applied but I am doing a
clock sweep over the queue and you probably caught a spot I was nearing.

The rest is clearly hard to digest. Ideally I could group all related
patches together, and separate the pure TODO items from the patches that
might be TODO items or might be applied. (Though I do need comments on
the pure TODO items too.)

The problem is that I know of no easy way to do that and the time to
doing it is better spent actually processing/deleting items.

> I did manage to find actual patches, but I had then to resort to my own
> mailbox to get the actual patch to apply and review.

You can download an mbox of the entire queue if that helps.

> Now I can't be sure whether the current commitfest is finished or there
> are still patches pending review; what patches could use input from me;
> what patches I could bounce to the next commitfest.
>
> Also I don't know what patches we have for the next commitfest. I would
> gladly give some time to put up a Wiki page to list the patches for the
> next commitfest. Would that be helpful?

Uh, I don't think we have any patches for the next commit fest yet.

--
Bruce Momjian <bruce@momjian.us> http://momjian.us
EnterpriseDB http://postgres.enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

-
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Bruce Momjian <bruce@momjian.us> writes:
>> Also I don't know what patches we have for the next commitfest. I would
>> gladly give some time to put up a Wiki page to list the patches for the
>> next commitfest. Would that be helpful?

> Uh, I don't think we have any patches for the next commit fest yet.

There are two or three items that we have decided to hold over, although
maybe it is sufficient if they are entered as TODOs.

Also, we *have* received several patches since the start of commit fest.
Somebody needs to check through them and see which are revisions of
patches already in the queue (legit material for this fest) and which
are new stuff (not so much).

regards, tom lane

-
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Bruce Momjian wrote:
> Alvaro Herrera wrote:

> > I did manage to find actual patches, but I had then to resort to my own
> > mailbox to get the actual patch to apply and review.
>
> You can download an mbox of the entire queue if that helps.

Ah, yeah, that's what I did.


> > Also I don't know what patches we have for the next commitfest. I would
> > gladly give some time to put up a Wiki page to list the patches for the
> > next commitfest. Would that be helpful?
>
> Uh, I don't think we have any patches for the next commit fest yet.

We certainly have, for example

http://archives.postgresql.org/pgsql...3/msg00245.php

Simon has been submitting patches as well.

--
Alvaro Herrera http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.

-
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Tom Lane wrote:
> Bruce Momjian <bruce@momjian.us> writes:
> >> Also I don't know what patches we have for the next commitfest. I would
> >> gladly give some time to put up a Wiki page to list the patches for the
> >> next commitfest. Would that be helpful?
>
> > Uh, I don't think we have any patches for the next commit fest yet.
>
> There are two or three items that we have decided to hold over, although
> maybe it is sufficient if they are entered as TODOs.
>
> Also, we *have* received several patches since the start of commit fest.
> Somebody needs to check through them and see which are revisions of
> patches already in the queue (legit material for this fest) and which
> are new stuff (not so much).

New stuff, as far as I can tell, but I will recheck.

--
Bruce Momjian <bruce@momjian.us> http://momjian.us
EnterpriseDB http://postgres.enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

-
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Alvaro Herrera wrote:
> Bruce Momjian wrote:
> > Alvaro Herrera wrote:
>
> > > I did manage to find actual patches, but I had then to resort to my own
> > > mailbox to get the actual patch to apply and review.
> >
> > You can download an mbox of the entire queue if that helps.
>
> Ah, yeah, that's what I did.
>
>
> > > Also I don't know what patches we have for the next commitfest. I would
> > > gladly give some time to put up a Wiki page to list the patches for the
> > > next commitfest. Would that be helpful?
> >
> > Uh, I don't think we have any patches for the next commit fest yet.
>
> We certainly have, for example
>
> http://archives.postgresql.org/pgsql...3/msg00245.php
>
> Simon has been submitting patches as well.

I mean we haven't added any for the next one, but I could move them to
patches_hold, I guess.

--
Bruce Momjian <bruce@momjian.us> http://momjian.us
EnterpriseDB http://postgres.enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

-
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Alvaro Herrera wrote:
>
> Also I don't know what patches we have for the next commitfest. I would
> gladly give some time to put up a Wiki page to list the patches for the
> next commitfest. Would that be helpful?
>
>

Yes. My experience is similar to yours. I'm not prepared to spend hours
perusing a mailbox again. We have unfortunately been badly underprepared
for this.

cheers

andrew

-
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

"Bruce Momjian" <bruce@momjian.us> writes:

> Alvaro Herrera wrote:
>>
>> I'm not sure I follow. I tried last week to give some hours for patch
>> review. What actually happened was that I had to wade through a ton of
>> stuff, skipping patches that were already applied, threads that were
>> purely discussion but not patches, threads about earlier versions of
>> some patches.
>
> Yep, that describes the painful process well.
>
> I have tried to stay on top of patches already applied but I am doing a
> clock sweep over the queue and you probably caught a spot I was nearing.

I've also tried to find stuff I could review and failed repeatedly. I have a
week now where I could spend a lot of time on this so I'll try again.

Am i looking at the right list though? The one I'm looking at still starts
with a patch to which Tom commented "This is superseded by a later submission"
which I think has been there since pretty much the start of the commitfest.

> You can download an mbox of the entire queue if that helps.
>>
>> Also I don't know what patches we have for the next commitfest. I would
>> gladly give some time to put up a Wiki page to list the patches for the
>> next commitfest. Would that be helpful?

I tried this once already. I dumped the first page of Bruce's queue into a
wiki page and laid it out in a column. But I wanted to add links back to the
messages in the archive and ran into a problem with that. It also would have
been a pain because Bruce's list is divided up into pages.

If we modify the archives to have a URL to go straight to a message-id and
Bruce generated a list all on one page including comments and message-ids then
I could process them all into a wiki page in a few hours.

--
Gregory Stark
EnterpriseDB http://www.enterprisedb.com
Ask me about EnterpriseDB's RemoteDBA services!

-
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Gregory Stark <stark@enterprisedb.com> writes:
> Am i looking at the right list though? The one I'm looking at still starts
> with a patch to which Tom commented "This is superseded by a later submission"
> which I think has been there since pretty much the start of the commitfest.

Yeah, there is still a boatload of stuff that could be removed from the
patch queue. I think that Bruce is intentionally leaving in all traffic
related to an open patch, which is okay by me as long as the obsolete
versions are properly commented. But I wish he'd get on with removing
the stuff that is marked as already committed (some in 8.3!).

> It also would have
> been a pain because Bruce's list is divided up into pages.

That's been a pain in the rear since the start. Bruce, could we combine
it into one page now that it's relatively short?

regards, tom lane

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers