Re: src/tools/pginclude considered harmful (was Re: [PATCHES]

#1 (**permalink**) 04-12-2008, 03:28 AM

Bruce Momjian <bruce@momjian.us> writes:
> Tom Lane wrote:
>> BTW, one of the remaining holes in pgrminclude is that it compiles with
>> -fsyntax-only, which apparently causes it to fail to detect some errors
>> of significance --- I assume that's how it managed to foul up lmgr.c,
>> inet_net_ntop.c, etc.

> But I do run a full compile and regression before commit, so that should
> have caught it even if pgrminclude didn't.

Doesn't catch warnings (unless you add -Werror during the build, which
will have problems with the remaining expected warnings...)

regards, tom lane

---------------------------(end of broadcast)---------------------------
TIP 6: explain analyze is your friend

Thread Tools
Show Printable Version Email this Page
Display Modes
Linear Mode Switch to Hybrid Mode Switch to Threaded Mode