Just a minor thing. In yesno_prompt(), the value is resp is allocated
memory that is never freed.

File: src/bin/scripts/common.c
Line: 218

Not terribly important though, it's not used in critical utilities, but
it's used often.

Found by coverity.
--
Martijn van Oosterhout <kleptog@svana.org> http://svana.org/kleptog/
> From each according to his ability. To each according to his ability to litigate.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)

iD8DBQFFItO3IB7bNG8LQkwRAk2bAKCB3AKuon35YAMOEjixN7 P9HQeoBgCeOWpF
5/GvkeMtRwlncGBP9MG2qXw=
=FBVw
-----END PGP SIGNATURE-----

Martijn van Oosterhout wrote:
> Just a minor thing. In yesno_prompt(), the value is resp is allocated
> memory that is never freed.
>
> File: src/bin/scripts/common.c
> Line: 218
>
> Not terribly important though, it's not used in critical utilities, but
> it's used often.
>
> Found by coverity.
>

It is surely not the only memory leak. We know there are some and in
most cases (like this) they aren't worth the trouble to clean up. If it
were used in psql or the backend I'd be worried, but it isn't, so I'm not.

cheers

andrew

---------------------------(end of broadcast)---------------------------
TIP 1: if posting/reading through Usenet, please send an appropriate
subscribe-nomail command to majordomo@postgresql.org so that your
message can get through to the mailing list cleanly

A good spot

Sorry for being no{isy}{vice}{wbie}, but what does it means "found by
coverity" ?

g.-

On 10/3/06, Martijn van Oosterhout <kleptog@svana.org> wrote:
> Just a minor thing. In yesno_prompt(), the value is resp is allocated
> memory that is never freed.
>
> File: src/bin/scripts/common.c
> Line: 218
>
> Not terribly important though, it's not used in critical utilities, but
> it's used often.
>
> Found by coverity.
> --
> Martijn van Oosterhout <kleptog@svana.org> http://svana.org/kleptog/
> > From each according to his ability. To each according to his ability to litigate.
>
>
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.1 (GNU/Linux)
>
> iD8DBQFFItO3IB7bNG8LQkwRAk2bAKCB3AKuon35YAMOEjixN7 P9HQeoBgCeOWpF
> 5/GvkeMtRwlncGBP9MG2qXw=
> =FBVw
> -----END PGP SIGNATURE-----
>
>
>


--
Guido Barosio
-----------------------
http://www.globant.com
guido.barosio@globant.com

---------------------------(end of broadcast)---------------------------
TIP 5: don't forget to increase your free space map settings

http://en.wikipedia.org/wiki/Coverity

[]'s
- Walter

On 10/3/06, Guido Barosio <gbarosio@gmail.com> wrote:
>
> A good spot
>
> Sorry for being no{isy}{vice}{wbie}, but what does it means "found by
> coverity" ?
>
> g.-
>
> On 10/3/06, Martijn van Oosterhout <kleptog@svana.org> wrote:
> > Just a minor thing. In yesno_prompt(), the value is resp is allocated
> > memory that is never freed.
> >
> > File: src/bin/scripts/common.c
> > Line: 218
> >
> > Not terribly important though, it's not used in critical utilities, but
> > it's used often.
> >
> > Found by coverity.
> > --
> > Martijn van Oosterhout <kleptog@svana.org> http://svana.org/kleptog/
> > > From each according to his ability. To each according to his ability
> to litigate.
> >
> >
> > -----BEGIN PGP SIGNATURE-----
> > Version: GnuPG v1.4.1 (GNU/Linux)
> >
> > iD8DBQFFItO3IB7bNG8LQkwRAk2bAKCB3AKuon35YAMOEjixN7 P9HQeoBgCeOWpF
> > 5/GvkeMtRwlncGBP9MG2qXw=
> > =FBVw
> > -----END PGP SIGNATURE-----
> >
> >
> >
>
>
> --
> Guido Barosio
> -----------------------
> http://www.globant.com
> guido.barosio@globant.com
>
> ---------------------------(end of broadcast)---------------------------
> TIP 5: don't forget to increase your free space map settings
>

On Tue, Oct 03, 2006 at 05:27:31PM -0400, Andrew Dunstan wrote:
> It is surely not the only memory leak. We know there are some and in
> most cases (like this) they aren't worth the trouble to clean up. If it
> were used in psql or the backend I'd be worried, but it isn't, so I'm not.

Ofcourse not. You don't see any messages about the other >100 leaks
found because I figure they're not worth the effort. This function is
used widely enough and a simple enough fix that I figured I might be
worth fixing.

Have a nice day,
--
Martijn van Oosterhout <kleptog@svana.org> http://svana.org/kleptog/
> From each according to his ability. To each according to his ability to litigate.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)

iD8DBQFFI4L7IB7bNG8LQkwRAvgnAJ9nPr1CXDYyO6NBqHQXcp RO9Kd+EgCfY5c2
SsycmpbGC6Bitt8VVI+mz9o=
=f6En
-----END PGP SIGNATURE-----