OK, I have spent some time generating and filtering typdefs via objdump
on various platforms. I filtered them and Bruce's list to eliminate
items not actually found in the sources thus:

while read line ; do grep -q -w -r --exclude="*.data" --exclude="*.out"
--exclude="*.sql" --exclude="*.po" --exclude='*akefile' $line
pgsql.head/src/backend pgsql.head/src/include pgsql.head/src/bin
pgsql.head/src/interfaces pgsql.head/src/pl pgsql.head/src/port
pgsql.head/src/timezone/*.[ch] pgsql.head/src/test/regress/*.[ch]
pgsql.head/contrib && echo $line; done

(This filter runs a lot faster than the one Alvaro posted.)

If someone can point me where to get objdump for OSX I'll look at
generating a list there too.

The results can be seen at:

http://developer.postgresql.org/~adunstan/linux-found
http://developer.postgresql.org/~adunstan/mingw-found
http://developer.postgresql.org/~adunstan/cygwin-found
http://developer.postgresql.org/~adu...ce-bsdos-found

counts:

2010 bruce-bsdos-found
2036 cygwin-found
1979 linux-found
2125 mingw-found


It seems clear (as we expected) that this process is sensitive to both
the build system and build options used. It's not just additive, though.
Bruce has some symbols that my linux build doesn't have because he
didn't build with openssh.

So I continue to think the best way to generate a list will be to
consolidate lists generated from the buildfarm which represents a wide
variety of build scenarios.

Is anyone else looking at GNU indent to see if it has improved enough to
meet our needs?

cheers

andrew

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Andrew Dunstan wrote:
> So I continue to think the best way to generate a list will be to
> consolidate lists generated from the buildfarm which represents a wide
> variety of build scenarios.
>
> Is anyone else looking at GNU indent to see if it has improved enough to
> meet our needs?

I am not going to be able to test GNU indent for a few months so I hope
someone else tests it sooner than that.

Just checking, but you remembered that GNU indent needs a typedef list
too, right? Also, there are scripts in pgindent surrounding the indent
binary that should also be reviewed.

--
Bruce Momjian <bruce@momjian.us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Bruce Momjian wrote:
> Andrew Dunstan wrote:
>
>> So I continue to think the best way to generate a list will be to
>> consolidate lists generated from the buildfarm which represents a wide
>> variety of build scenarios.
>>
>> Is anyone else looking at GNU indent to see if it has improved enough to
>> meet our needs?
>>
>
> I am not going to be able to test GNU indent for a few months so I hope
> someone else tests it sooner than that.
>
> Just checking, but you remembered that GNU indent needs a typedef list
> too, right? Also, there are scripts in pgindent surrounding the indent
> binary that should also be reviewed.
>
>

Right now I am addressing the very specific problem of coming up with a
better typedef list to use with whatever indenter we use, given that it
seems a task well suited to the buildfarm.

If I do get to looking at GNU indent it will be a way down the track for
me too. In fact, this seems a task that might be well suited to someone
who is not spending what time they have available for Postgres on
hacking (currently I'm trying to remove bitrot from the column level
privs patch).

cheers

andrew

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Andrew Dunstan wrote:
>
> OK, I have spent some time generating and filtering typdefs via objdump
> on various platforms. I filtered them and Bruce's list to eliminate
> items not actually found in the sources thus:

Did this go anywhere?

--
Alvaro Herrera http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Alvaro Herrera wrote:
> Andrew Dunstan wrote:
>
>> OK, I have spent some time generating and filtering typdefs via objdump
>> on various platforms. I filtered them and Bruce's list to eliminate
>> items not actually found in the sources thus:
>>
>
> Did this go anywhere?
>


I'm still trying to get a working objdump for OSX. Automating this is
difficult because we need to make sure we get all (or pretty close to
all) the typedefs we can get on each platform for various build
configurations.

cheers

andrew

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Andrew Dunstan wrote:
>
>
> Alvaro Herrera wrote:
> > Andrew Dunstan wrote:
> >
> >> OK, I have spent some time generating and filtering typdefs via objdump
> >> on various platforms. I filtered them and Bruce's list to eliminate
> >> items not actually found in the sources thus:
> >>
> >
> > Did this go anywhere?
> >
>
>
> I'm still trying to get a working objdump for OSX. Automating this is
> difficult because we need to make sure we get all (or pretty close to
> all) the typedefs we can get on each platform for various build
> configurations.

At this point I would like to get a typedef list into CVS, even if it is
not perfect --- it is better than what we have now.

--
Bruce Momjian <bruce@momjian.us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Bruce Momjian wrote:
> Andrew Dunstan wrote:
>
>> Alvaro Herrera wrote:
>>
>>> Andrew Dunstan wrote:
>>>
>>>
>>>> OK, I have spent some time generating and filtering typdefs via objdump
>>>> on various platforms. I filtered them and Bruce's list to eliminate
>>>> items not actually found in the sources thus:
>>>>
>>>>
>>> Did this go anywhere?
>>>
>>>
>> I'm still trying to get a working objdump for OSX. Automating this is
>> difficult because we need to make sure we get all (or pretty close to
>> all) the typedefs we can get on each platform for various build
>> configurations.
>>
>
> At this point I would like to get a typedef list into CVS, even if it is
> not perfect --- it is better than what we have now.
>
>

Well, you can start with this one:

http://www.pgbuildfarm.org/cgi-bin/s...6&stg=typedefs

After I have a number of buildfarm machines producing them, I'll work on
a stored proc to consolidate them and make them available, probably via
a SOAP call (c.f.
http://people.planetpostgresql.org/a...dashboard.html
)


cheers

andrew

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers