Unix Technical Forum

Patch for snprintf problem (bug #1000650)

This is a discussion on Patch for snprintf problem (bug #1000650) within the pgsql Interfaces odbc forums, part of the PostgreSQL category; --> Ludek Finstrle wrote: > Tue, Jun 13, 2006 at 11:12:58PM +0900, Hiroshi Inoue wrote: > >> Ludek Finstrle wrote: ...


Go Back   Unix Technical Forum > Database Server Software > PostgreSQL > pgsql Interfaces odbc

FAQ Members List Calendar Search Today's Posts Mark Forums Read
  #11 (permalink)  
Old 04-16-2008, 02:01 AM
Hiroshi Inoue
 
Posts: n/a
Default Re: Patch for snprintf problem (bug #1000650) 5-th try

Ludek Finstrle wrote:
> Tue, Jun 13, 2006 at 11:12:58PM +0900, Hiroshi Inoue wrote:
>
>> Ludek Finstrle wrote:
>>
>>> I make patch againist CVS after yours huge commit. What's your opinion?
>>>
>>>

>> Is the second parameter of snprintf_add needed ?
>> Aren't the parameter values always strlen(the first parameter) ?
>>

>
> You're right. I think more about it and "add" means add to the end
> so I changed the patch as you pointed.
>
>
>> Is snprintf_len needed instead of snprintf ?
>> Though the current code ignores snprintf errors, it's simply
>> my negligence..
>>

>
> I'm voting for keeping safer snprintf_len. But I can change it if
> you wish.
>
> New patch attached.
>


OK please commit it.

regards,
Hiroshi Inoue

---------------------------(end of broadcast)---------------------------
TIP 6: explain analyze is your friend

Digg this Post!Add Post to del.icio.usBookmark Post in TechnoratiFurl this Post!
Reply With Quote
  #12 (permalink)  
Old 04-16-2008, 02:01 AM
Ludek Finstrle
 
Posts: n/a
Default Re: Patch for snprintf problem (bug #1000650) 5-th try

> OK please commit it.

Patch commited.

Thanks,

Luf

---------------------------(end of broadcast)---------------------------
TIP 4: Have you searched our list archives?

http://archives.postgresql.org

Digg this Post!Add Post to del.icio.usBookmark Post in TechnoratiFurl this Post!
Reply With Quote
Reply


Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

vB code is On
Smilies are On
[IMG] code is On
HTML code is Off
Trackbacks are On
Pingbacks are On
Refbacks are On
Forum Jump


All times are GMT. The time now is 08:42 PM.


Powered by vBulletin® Version 3.6.5
Copyright ©2000 - 2008, Jelsoft Enterprises Ltd.
SEO by vBSEO 3.2.0
www.UnixAdminTalk.com