Unix Technical Forum

Re: Please review this patch

This is a discussion on Re: Please review this patch within the pgsql Interfaces odbc forums, part of the PostgreSQL category; --> > -----Original Message----- > From: Ludek Finstrle [mailto:luf@pzkagis.cz] > Sent: 09 December 2005 10:52 > To: Dave Page > ...


Go Back   Unix Technical Forum > Database Server Software > PostgreSQL > pgsql Interfaces odbc

FAQ Members List Calendar Search Today's Posts Mark Forums Read
  #1 (permalink)  
Old 04-16-2008, 02:38 AM
Dave Page
 
Posts: n/a
Default Re: Please review this patch



> -----Original Message-----
> From: Ludek Finstrle [mailto:luf@pzkagis.cz]
> Sent: 09 December 2005 10:52
> To: Dave Page
> Cc: pgsql-odbc@postgresql.org
> Subject: Re: [ODBC] Please review this patch
>
> > > I prepared fix for Bug "Autocommit and Cancel". It's

> woking patch
> > > (it's used #ifded NOT_USED). The main changes are in

> using cancelable
> > > PQsendQuery (it could be ok) and in cleaning and correcting
> > > CC_send_query. CC_send_query should be equivalent with old one
> > > except adding some QR_set_aborted. I'm not sure if it's ok.
> > > It passed ok throught few tests.
> > >
> > > Please could you take a look at this patch? Comments are welcome.

> >
> > Think you forgot to attach the patch Luf :-)

>
> Ops, my fault. Second try ...


OK, I've bashed it around a fair bit and can't find any regressions over
the previous code, so I'll commit the code. I don't have any threaded
test code to properly test SQLCancel with at the moment though, so
perhaps the original reporter can test that.

Regards, Dave.

---------------------------(end of broadcast)---------------------------
TIP 1: if posting/reading through Usenet, please send an appropriate
subscribe-nomail command to majordomo@postgresql.org so that your
message can get through to the mailing list cleanly

Digg this Post!Add Post to del.icio.usBookmark Post in TechnoratiFurl this Post!
Reply With Quote
  #2 (permalink)  
Old 04-16-2008, 02:38 AM
Ludek Finstrle
 
Posts: n/a
Default Re: Please review this patch

> OK, I've bashed it around a fair bit and can't find any regressions over
> the previous code, so I'll commit the code. I don't have any threaded
> test code to properly test SQLCancel with at the moment though, so
> perhaps the original reporter can test that.


Ok, I'll include it in next development snapshot.
Thare is a lot of problems with SQLCancel. It needs huge changes.
I think I clean the code at first. There is a lot of dead ends.

Thanks,

Luf

---------------------------(end of broadcast)---------------------------
TIP 1: if posting/reading through Usenet, please send an appropriate
subscribe-nomail command to majordomo@postgresql.org so that your
message can get through to the mailing list cleanly

Digg this Post!Add Post to del.icio.usBookmark Post in TechnoratiFurl this Post!
Reply With Quote
Reply


Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

vB code is On
Smilies are On
[IMG] code is On
HTML code is Off
Trackbacks are On
Pingbacks are On
Refbacks are On
Forum Jump


All times are GMT. The time now is 09:07 PM.


Powered by vBulletin® Version 3.6.5
Copyright ©2000 - 2008, Jelsoft Enterprises Ltd.
SEO by vBSEO 3.2.0
www.UnixAdminTalk.com