> -----Original Message-----
> From: Ludek Finstrle [mailto:luf@pzkagis.cz]
> Sent: 02 December 2005 14:38
> To: Dave Page
> Cc: pgsql-odbc@postgresql.org
> Subject: Re: [ODBC] Some changes
>
> > The attached patch clears out any parameters during SQLCancel. This
> > works for the test case, and seems to not hurt any of my
> apps that I've
> > quickly tested. I definitely want some feedback before I apply this
> > though please :-)
>
> I see (endly) ODBC specification and it's ok to free all parameters
> when SQLCancel is called during awaiting data (SQL_NEED_DATA).
> Only comment in patch is little bit strenge.
>
> I have to more study ODBC specification. It's mine bottleneck.

And mine :-(. I'm pretty sure the patch is within the spec though (and
frankly, I'm more concerned that the driver works as most popular
applications expect than 100% to the spec which is pretty much the line
taken by previous maintainers).

Anyhoo, please let me know if you think it's good to apply when you've
taken a look at it - I'd appreciate the feedback on this one!

Regards, Dave

---------------------------(end of broadcast)---------------------------
TIP 4: Have you searched our list archives?

http://archives.postgresql.org

> > Only comment in patch is little bit strenge.

I'm sorry. I post only second part of my reviewing the patch.

> Anyhoo, please let me know if you think it's good to apply when you've
> taken a look at it - I'd appreciate the feedback on this one!

It looks good to me except the comment. SQLFreeStmt do the freeing
bind params same way as you implement in SQLCancel. This is better
way.

I try create first development snapshot yesterday. I didn't announce it.
Do you agree I add this patch to the snapshot and re-release it
with announcement here? So more people can test it.

Thanks

Luf

---------------------------(end of broadcast)---------------------------
TIP 5: don't forget to increase your free space map settings