> -----Original Message-----
> From: pgadmin-hackers-owner@postgresql.org
> [mailtogadmin-hackers-owner@postgresql.org] On Behalf Of Miha Radej
> Sent: 27 May 2006 16:03
> To: pgadmin-hackers
> Subject: [pgadmin-hackers] Compiling pgAdmin on SuSE 10.1
>
> Hi!
>
> I tried to compile pgAdmin on a Suse 10.1 system, using a fresh SVN
> checkout (rev 5210).
>
> Attached is a patch with changes I had to apply in order to be able to
> compile pgAdmin.

Thanks - applied. We really need a buildfarm....

> I also got the following warnings while compiling pgAdmin - got them
> before and after adding the headers, only line numbers differ:
>
> ./frm/frmReport.cpp: In member function 'virtual void
> reportObjectDataDictionaryFactory::GenerateReport( frmReport*,
> pgObject*)':
> ./frm/frmReport.cpp:1335: warning: cannot pass objects of non-POD type
> 'class wxString' through '...'; call will abort at runtime

Yeah, these ones only fail on GCC - it's complaining about passing a
wxString as a parameter to a variadic function. The fix is to use the
c_str() member, eg.

printf("%s: %s", sqlState.c_str(), errMsg.c_str());

It's easy to forget :-(

Thanks, Dave.

---------------------------(end of broadcast)---------------------------
TIP 9: In versions below 8.0, the planner will ignore your desire to
choose an index scan if your joining column's datatypes do not
match

Hi!

Dave Page pravi:
>> ./frm/frmReport.cpp: In member function 'virtual void
>> reportObjectDataDictionaryFactory::GenerateReport( frmReport*,
>> pgObject*)':
>> ./frm/frmReport.cpp:1335: warning: cannot pass objects of non-POD type
>> 'class wxString' through '...'; call will abort at runtime
>
> Yeah, these ones only fail on GCC - it's complaining about passing a
> wxString as a parameter to a variadic function. The fix is to use the
> c_str() member, eg.

The above warnings are now gone, but I noticed these now:

../frm/frmEditGrid.cpp: In member function ‘void sqlTable::Paste()’:
../frm/frmEditGrid.cpp:1840: warning: comparison between signed and
unsigned integer expressions
../frm/frmEditGrid.cpp:1841: warning: comparison between signed and
unsigned integer expressions
../frm/frmEditGrid.cpp:1856: warning: comparison between signed and
unsigned integer expressions
../frm/frmEditGrid.cpp:1857: warning: comparison between signed and
unsigned integer expressions

The attached patch is yet another "works for me" kind of patch, I don't
know what good/standard C++ practice is in such situations, considering
I don't know C++ at all

Regards,
Miha

--
"... the small primitive tribes joined up and became huge, powerful
primitive tribes with more sophisticated weapons."
-- Terry Pratchett, Small Gods


---------------------------(end of broadcast)---------------------------
TIP 9: In versions below 8.0, the planner will ignore your desire to
choose an index scan if your joining column's datatypes do not
match