> -----Original Message-----
> From: blacknoz@club-internet.fr [mailto:blacknoz@club-internet.fr]
> Sent: 13 May 2005 16:49
> To: Dave Page; fgp@phlo.org; pgadmin-hackers@postgresql.org
> Subject: Re: Re: [pgadmin-hackers] [PATCH] Appbundle-Support for 1.2
>
> Hi Dave, Florian,
>
> ----Message d'origine----
> >Sujet: Re: [pgadmin-hackers] [PATCH] Appbundle-Support for 1.2
> >Date: Fri, 13 May 2005 12:55:32 +0100
> >De: "Dave Page" <dpage@vale-housing.co.uk>
> >A: "Florian G. Pflug" <fgp@phlo.org>,
> >
> >Thanks Florian - patch applied.
> >
> >Can you test and confirm the committed version works OK please? I'll
> >probably need you to do so again following any changes that
> Raph submits
> >for Debian if that's OK.
>
> I just took a quick look to the patch provided by Florian. I
> didn't try the build yet and I may be wrong, but to me it
> does not handle the "DESTDIR" problem and refers to PREFIX,
> not DESTDIR.
> However, I'll try that tonight. Florian, can you confirm you
> were referring to DESTDIR and not PREFIX ?
> Is there some magic that make PREFIX take DESTDIR as a parameter ?
>

Gmake/automake/autoconf is all black magic for me, hence why I'd rather
tackle one problem on on OS (that I don't have) at a time :-)

/D

---------------------------(end of broadcast)---------------------------
TIP 7: don't forget to increase your free space map settings

Dave Page wrote:
>
>
>
>>-----Original Message-----
>>From: blacknoz@club-internet.fr [mailto:blacknoz@club-internet.fr]
>>Sent: 13 May 2005 16:49
>>To: Dave Page; fgp@phlo.org; pgadmin-hackers@postgresql.org
>>Subject: Re: Re: [pgadmin-hackers] [PATCH] Appbundle-Support for 1.2
>>
>>Hi Dave, Florian,
>>
>>----Message d'origine----
>>
>>>Sujet: Re: [pgadmin-hackers] [PATCH] Appbundle-Support for 1.2
>>>Date: Fri, 13 May 2005 12:55:32 +0100
>>>De: "Dave Page" <dpage@vale-housing.co.uk>
>>>A: "Florian G. Pflug" <fgp@phlo.org>,
>>>
>>>Thanks Florian - patch applied.
>>>
>>>Can you test and confirm the committed version works OK please? I'll
>>>probably need you to do so again following any changes that
>>
>>Raph submits
>>
>>>for Debian if that's OK.
>>
>>I just took a quick look to the patch provided by Florian. I
>>didn't try the build yet and I may be wrong, but to me it
>>does not handle the "DESTDIR" problem and refers to PREFIX,
>>not DESTDIR.
>>However, I'll try that tonight. Florian, can you confirm you
>>were referring to DESTDIR and not PREFIX ?
>>Is there some magic that make PREFIX take DESTDIR as a parameter ?
>>
>
>
> Gmake/automake/autoconf is all black magic for me, hence why I'd rather
> tackle one problem on on OS (that I don't have) at a time :-)

So, let's continue the twist

attached is the patch that works for me and keeps what was added by
Florian. As I understand it, $(PREFIX) is the equivalent to "my"
$(DESTDIR). Is it specific to Mac OS X ? If not and if it can be
replaced by DESTDIR, I'd suggest removing "$(PREFIX)" ref from Makefile.am.

Florian, what do you think about it?

Regards,
Raphaël


---------------------------(end of broadcast)---------------------------
TIP 9: the planner will ignore your desire to choose an index scan if your
joining column's datatypes do not match

Raphaël Enrici wrote:
> Dave Page wrote:
>>>From: blacknoz@club-internet.fr [mailto:blacknoz@club-internet.fr]
>>>
>>>Hi Dave, Florian,
>>>
>>>I just took a quick look to the patch provided by Florian. I
>>>didn't try the build yet and I may be wrong, but to me it
>>>does not handle the "DESTDIR" problem and refers to PREFIX,
>>>not DESTDIR.
>>>However, I'll try that tonight. Florian, can you confirm you
>>>were referring to DESTDIR and not PREFIX ?
>>>Is there some magic that make PREFIX take DESTDIR as a parameter ?
>>
>>Gmake/automake/autoconf is all black magic for me, hence why I'd rather
>>tackle one problem on on OS (that I don't have) at a time :-)
>
> So, let's continue the twist
>
> attached is the patch that works for me and keeps what was added by
> Florian. As I understand it, $(PREFIX) is the equivalent to "my"
> $(DESTDIR). Is it specific to Mac OS X ? If not and if it can be
> replaced by DESTDIR, I'd suggest removing "$(PREFIX)" ref from Makefile.am.
>
> Florian, what do you think about it?

Dave, please apply Rapahels correction of my patch - I was just being
brain-dead ;-)

I meant to write "$(DESTDIR)" - but somehow I ended up typing
"$(PREFIX)", and didn't notice because $(PREFIX) is undefined,
and this empty.

Sorry for the confusion

greetings, Florian Pflug

---------------------------(end of broadcast)---------------------------
TIP 6: Have you searched our list archives?

http://archives.postgresql.org

Dave,

attached is the patch which both Florian and I think it solves the
DESTDIR issue in Makefile.am.

Regards,
Raphaël

Florian G. Pflug wrote:
> Raphaël Enrici wrote:
>
>>Dave Page wrote:
>>
>>>>From: blacknoz@club-internet.fr [mailto:blacknoz@club-internet.fr]
>>>>
>>>>Hi Dave, Florian,
>>>>
>>>>I just took a quick look to the patch provided by Florian. I
>>>>didn't try the build yet and I may be wrong, but to me it
>>>>does not handle the "DESTDIR" problem and refers to PREFIX,
>>>>not DESTDIR.
>>>>However, I'll try that tonight. Florian, can you confirm you
>>>>were referring to DESTDIR and not PREFIX ?
>>>>Is there some magic that make PREFIX take DESTDIR as a parameter ?
>>>
>>>Gmake/automake/autoconf is all black magic for me, hence why I'd rather
>>>tackle one problem on on OS (that I don't have) at a time :-)
>>
>>So, let's continue the twist
>>
>>attached is the patch that works for me and keeps what was added by
>>Florian. As I understand it, $(PREFIX) is the equivalent to "my"
>>$(DESTDIR). Is it specific to Mac OS X ? If not and if it can be
>>replaced by DESTDIR, I'd suggest removing "$(PREFIX)" ref from Makefile.am.
>>
>>Florian, what do you think about it?
>
>
> Dave, please apply Rapahels correction of my patch - I was just being
> brain-dead ;-)
>
> I meant to write "$(DESTDIR)" - but somehow I ended up typing
> "$(PREFIX)", and didn't notice because $(PREFIX) is undefined,
> and this empty.
>
> Sorry for the confusion
>
> greetings, Florian Pflug
>
> ---------------------------(end of broadcast)---------------------------
> TIP 6: Have you searched our list archives?
>
> http://archives.postgresql.org
>


--
Raphaël Enrici blacknoz@club-internet.fr
-- ICQ: 207246758 / Jabber: blacknoz@jabber.org --
-- Use Debian GNU/Linux http://www.debian.org/ --
-- Use pgAdmin http://www.pgadmin.org/ --


---------------------------(end of broadcast)---------------------------
TIP 1: subscribe and unsubscribe commands go to majordomo@postgresql.org