Unix Technical Forum

Re: [PATCH] Patches for pg_dumpall, complete-bundle.shand dmg creation

This is a discussion on Re: [PATCH] Patches for pg_dumpall, complete-bundle.shand dmg creation within the pgsql Interfaces Pgadmin Hackers forums, part of the PostgreSQL category; --> Florian G. Pflug wrote: > Hi > > Here are various small patches I created today. > > 1) ...


Go Back   Unix Technical Forum > Database Server Software > PostgreSQL > pgsql Interfaces Pgadmin Hackers

FAQ Members List Calendar Search Today's Posts Mark Forums Read
  #1 (permalink)  
Old 04-17-2008, 07:38 PM
Dave Page
 
Posts: n/a
Default Re: [PATCH] Patches for pg_dumpall, complete-bundle.shand dmg creation

Florian G. Pflug wrote:
> Hi
>
> Here are various small patches I created today.
>
> 1) The first
> (pgadmin3-dumpall.patch) adds pg_dumpall to the list
> of postgres binaries that are copied into the app bundle.


Thanks, applied.

> 2) When testing that one, I noticed that complete-bundle.sh seems
> to be broken - at lost on my 10.3.9 buildserver. The reason is
> that awk is called with "-F: -F\ " - which I guess ist meant to
> mean "treat either a color or a space as field seperator". It
> seems, however, that the second -F just overrides that first,
> and therefore the filename followed by a colon is put into todo_obj,
> instead of just the filename. Since -F takes a regex as parameter,
> the fix is easy - just use ":| " as parameter to -F. While I was
> at it, I also changed the output record seperator from newline (default)
> to space. This is purely cosemtic, but makes the output of the script
> a bit more readable. This patch should probably be applied to head and
> 1.6.


Done. Seems to work fine here.

>
> 3) The last patch ist a first shot at a create-dmg script. It seems to work
> quite fine - it even attaches a license to the dmg that the user has to
> accept before the dmg is mounted ;-)


Cool - works a treat here so I've replaced the installer with it in
-head. It'd be really cool if you could work up one of those funky
background graphics for the finder window that hint on how to install
into the Applications dir. Hint, hint :-)

Thanks for the patches :-)

Regards, Dave.

---------------------------(end of broadcast)---------------------------
TIP 5: don't forget to increase your free space map settings

Digg this Post!Add Post to del.icio.usBookmark Post in TechnoratiFurl this Post!
Reply With Quote
  #2 (permalink)  
Old 04-17-2008, 07:38 PM
Florian G. Pflug
 
Posts: n/a
Default Re: [PATCH] Patches for pg_dumpall, complete-bundle.shand dmg creation

Dave Page wrote:
> Florian G. Pflug wrote:
>> 3) The last patch ist a first shot at a create-dmg script. It seems to
>> work
>> quite fine - it even attaches a license to the dmg that the user has to
>> accept before the dmg is mounted ;-)

>
> Cool - works a treat here so I've replaced the installer with it in
> -head. It'd be really cool if you could work up one of those funky
> background graphics for the finder window that hint on how to install
> into the Applications dir. Hint, hint :-)


Yeah, I'd like to do that ;-) If only there was more documentation on
disk images available...

greetings, Florian Pflujg


---------------------------(end of broadcast)---------------------------
TIP 2: Don't 'kill -9' the postmaster

Digg this Post!Add Post to del.icio.usBookmark Post in TechnoratiFurl this Post!
Reply With Quote
Reply


Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

vB code is On
Smilies are On
[IMG] code is On
HTML code is Off
Trackbacks are On
Pingbacks are On
Refbacks are On
Forum Jump


All times are GMT. The time now is 02:08 AM.


Powered by vBulletin® Version 3.6.5
Copyright ©2000 - 2008, Jelsoft Enterprises Ltd.
SEO by vBSEO 3.2.0
www.UnixAdminTalk.com