vBulletin Search Engine Optimization
| |||||||
| Register | FAQ | Members List | Calendar | Search | Today's Posts | Mark Forums Read |
| ||||
| > -----Original Message----- > From: Andreas Pflug [mailto > Sent: 03 April 2006 16:06 > To: Dave Page > Cc: pgadmin-hackers > Subject: Re: [pgadmin-hackers] Query grid > > If the current implementation isn't rewritten, I'll commit a virtual > rewrite of wxListView based ctlSqlResult (as soon as I find the time, > which will certainly not be this week). It will probably require more > work on frmQuery (remove the ctl filling loop, no need for the second > timing display) than on the ctl itself, making it incompatible to > ctlSqlResult implementations that are not managing their data > virtually. Yeah, well hold fire on that - I just found what broke it, and now get (second of 2 runs in each version, from the same server): 1.5.0: -- Executing query: select * from pbx_log limit 10000 Total query runtime: 8187 ms. Data retrieval runtime: 1062 ms. 10000 rows retrieved. 1.4.1: -- Executing query: select * from pbx_log limit 10000 Total query runtime: 8187 ms. Data retrieval runtime: 9125 ms. 10000 rows retrieved. I was killing that query after a few minutes in 1.5.0 until I found the bug (introduced here: http://svn.pgadmin.org/cgi-bin/viewc...5068&view=rev). I'll find a netter way of solving that issue and commit the appropriate fixes. Now I don't think you can deny that with or without a virtual table, that definitely works better than the listview does - and that was tested on Mac and *nix. If you can improve it further then feel free, but please do not break the new copy 'n' paste capabilities. Regards, Dave ---------------------------(end of broadcast)--------------------------- TIP 6: explain analyze is your friend |
| |||
| Dave Page wrote: > > > >>-----Original Message----- >>From: Andreas Pflug [mailto >>Sent: 03 April 2006 16:06 >>To: Dave Page >>Cc: pgadmin-hackers >>Subject: Re: [pgadmin-hackers] Query grid >> >>If the current implementation isn't rewritten, I'll commit a virtual >>rewrite of wxListView based ctlSqlResult (as soon as I find the time, >>which will certainly not be this week). It will probably require more >>work on frmQuery (remove the ctl filling loop, no need for the second >>timing display) than on the ctl itself, making it incompatible to >>ctlSqlResult implementations that are not managing their data >>virtually. > > > Yeah, well hold fire on that - I just found what broke it, and now get > (second of 2 runs in each version, from the same server): > > 1.5.0: > > -- Executing query: > select * from pbx_log limit 10000 > > Total query runtime: 8187 ms. > Data retrieval runtime: 1062 ms. > 10000 rows retrieved. A correct implementation has *no* retrieval time, just some microseconds of setting up the virtual control. Regards, Andreas ---------------------------(end of broadcast)--------------------------- TIP 5: don't forget to increase your free space map settings |
| |||
| Andreas Pflug wrote: > A correct implementation has *no* retrieval time, just some > microseconds of setting up the virtual control. Do you have any advice on how exactly to implement that behavior? It looked like the View Data grid did it by only retrieving the actual results as they were needed. When I started on this, you were rather firm that the way the results were retrieved should not be altered in any way. If you want, I'll look into merging the virtual table from the View Data grid with the results grid. Ed ---------------------------(end of broadcast)--------------------------- TIP 2: Don't 'kill -9' the postmaster |
| ||||
| Edward Di Geronimo Jr. wrote: > Andreas Pflug wrote: > >> A correct implementation has *no* retrieval time, just some >> microseconds of setting up the virtual control. > > > Do you have any advice on how exactly to implement that behavior? > > It looked like the View Data grid did it by only retrieving the actual > results as they were needed. When I started on this, you were rather > firm that the way the results were retrieved should not be altered in > any way. > > If you want, I'll look into merging the virtual table from the View Data > grid with the results grid. As I said in an earlier mail, I'd expect more work on frmQuery than on ctlSqlResult(wxListView) to make it virtual. Implementing it will be probable faster for me than explaining what to do. I'm short on time, so if you insist on using wxGrid you're on your own. Regards, Andreas ---------------------------(end of broadcast)--------------------------- TIP 6: explain analyze is your friend |