SEO
vBulletin Search Engine Optimization
| |||||||
| Register | FAQ | Members List | Calendar | Search | Today's Posts | Mark Forums Read |
05-07-2008, 10:18 AM
| ||||
| ||||
 Statistics tab, "Tables" node Hi, When one clicks on the statistics tab with "Tables" node selected, very few statistics are shown : * tuples inserted * tuples updated * tuples deleted * size I'm wondering if we could put all pg_stat_all_tables columns here. That's a lot of informations, but at least some informations seem to be worth it : n_live_tup, n_dead_tup, last_vacuum, last_autovacuum, last_analyze, last_autoanalyze. I would also like to add some other stuff like the % of the table in cache (if pg_buffercache is available). Comments, ideas ? -- Guillaume. http://www.postgresqlfr.org http://dalibo.com -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers      |
|
05-07-2008, 10:18 AM
| |||
| |||
| Re: Statistics tab, "Tables" node Guillaume Lelarge wrote: > Hi, > > When one clicks on the statistics tab with "Tables" node selected, > very few statistics are shown : > * tuples inserted > * tuples updated > * tuples deleted > * size > > I'm wondering if we could put all pg_stat_all_tables columns here. > That's a lot of informations, but at least some informations seem to > be worth it : n_live_tup, n_dead_tup, last_vacuum, last_autovacuum, > last_analyze, last_autoanalyze. I would also like to add some other > stuff like the % of the table in cache (if pg_buffercache is > available). > > Comments, ideas ? +1 on the stuff from pg_stat (but make sure to check which columns are available in which version) -1 on the pg_buffercache stuff. That one can be populated using a special option I think, but since pg_buffercache takes out some fairly heavy locking, we shouldn't do that by default. //Magnus -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers |
|
05-07-2008, 10:18 AM
| |||
| |||
| Re: Statistics tab, "Tables" node Magnus Hagander a écrit : > Guillaume Lelarge wrote: >> [...] >> I'm wondering if we could put all pg_stat_all_tables columns here. >> That's a lot of informations, but at least some informations seem to >> be worth it : n_live_tup, n_dead_tup, last_vacuum, last_autovacuum, >> last_analyze, last_autoanalyze. I would also like to add some other >> stuff like the % of the table in cache (if pg_buffercache is >> available). >> >> Comments, ideas ? > > +1 on the stuff from pg_stat (but make sure to check which columns are > available in which version) > The patch attached takes care of this. > -1 on the pg_buffercache stuff. That one can be populated using a > special option I think, but since pg_buffercache takes out some fairly > heavy locking, we shouldn't do that by default. > I agree, it would be better to have an option (disabled by default). -- Guillaume. http://www.postgresqlfr.org http://dalibo.com -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers |
|
05-07-2008, 10:18 AM
| |||
| |||
| Re: Statistics tab, "Tables" node On Mon, May 5, 2008 at 4:38 PM, Guillaume Lelarge <guillaume@lelarge.info> wrote: > > > > +1 on the stuff from pg_stat (but make sure to check which columns are > > available in which version) > > > > > > The patch attached takes care of this. It looks good to me, except the individual table stats should also show the new data (ie. when you click on a single table). BTW, HOT update count is cool - didn't know we added that :-) The display is getting a little wide - I think it's OK for now, but if anything else gets added we need to think about better ways to present the data I think. What might be a nice enhancement, is some auto-sizing based on column heading width. Wanna take a peek at that as well? -- Dave Page EnterpriseDB UK: http://www.enterprisedb.com -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers |
|
05-07-2008, 10:18 AM
| |||
| |||
| Re: Statistics tab, "Tables" node Dave Page a écrit : > On Mon, May 5, 2008 at 4:38 PM, Guillaume Lelarge > <guillaume@lelarge.info> wrote: >>> +1 on the stuff from pg_stat (but make sure to check which columns are >>> available in which version) >>> >>> >> The patch attached takes care of this. > > It looks good to me, except the individual table stats should also > show the new data (ie. when you click on a single table). BTW, HOT > update count is cool - didn't know we added that :-) > Done. See attached patch. > The display is getting a little wide - I think it's OK for now, but if > anything else gets added we need to think about better ways to present > the data I think. > I completely agree. > What might be a nice enhancement, is some auto-sizing based on column > heading width. Wanna take a peek at that as well? > I'll get a look at it tonight. Can I apply this patch first and then work on the "auto-sizing columns" patch ? -- Guillaume. http://www.postgresqlfr.org http://dalibo.com -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers |
|
05-07-2008, 10:18 AM
| |||
| |||
| Re: Statistics tab, "Tables" node On Tue, May 6, 2008 at 2:49 PM, Guillaume Lelarge <guillaume@lelarge.info> wrote: > > What might be a nice enhancement, is some auto-sizing based on column > > heading width. Wanna take a peek at that as well? > > > I'll get a look at it tonight. Can I apply this patch first and then work on > the "auto-sizing columns" patch ? Sure, go ahead. Thanks, Dave -- Dave Page EnterpriseDB UK: http://www.enterprisedb.com -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers |
|
05-07-2008, 10:18 AM
| |||
| |||
| Re: Statistics tab, "Tables" node Dave Page a écrit : > On Tue, May 6, 2008 at 2:49 PM, Guillaume Lelarge > <guillaume@lelarge.info> wrote: >>> What might be a nice enhancement, is some auto-sizing based on column >>> heading width. Wanna take a peek at that as well? >>> >> I'll get a look at it tonight. Can I apply this patch first and then work on >> the "auto-sizing columns" patch ? > > Sure, go ahead. > Done, thanks. -- Guillaume. http://www.postgresqlfr.org http://dalibo.com -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers |
|
05-13-2008, 06:16 PM
| |||
| |||
| Re: Statistics tab, "Tables" node Dave Page a écrit : > [...] > What might be a nice enhancement, is some auto-sizing based on column > heading width. Wanna take a peek at that as well? > I finally found some time to work on this. wxwidgets allows to specify two "default" values : * wxLIST_AUTOSIZE * wxLIST_AUTOSIZE_USEHEADER The last one does what we want, but our ctlListView::AddColumn method's handling of default values was buggy. The attached patch fixes this, and changes pgTableCollection::ShowStatistics method to handle the new default value (wxLIST_AUTOSIZE_USEHEADER). Do we want this for the 1.8 branch ? Obviously, this is a bug fix, but for the fix to really work, we need more changes (ie using the default value in each, at least some of them, call to ctlListView::AddColumn). Comments? -- Guillaume. http://www.postgresqlfr.org http://dalibo.com -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers |
|
05-13-2008, 06:16 PM
| |||
| |||
| Re: Statistics tab, "Tables" node Guillaume Lelarge a écrit : > [...] > The last one does what we want, but our ctlListView::AddColumn method's > handling of default values was buggy. The attached patch fixes this, and > changes pgTableCollection::ShowStatistics method to handle the new > default value (wxLIST_AUTOSIZE_USEHEADER). > /me wishes he has a mail client that would tell him he forgot the "attached patch" :-/ -- Guillaume. http://www.postgresqlfr.org http://dalibo.com -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers |
|
05-13-2008, 06:16 PM
| ||||
| ||||
| Re: Statistics tab, "Tables" node On Mon, May 12, 2008 at 10:21 AM, Guillaume Lelarge <guillaume@lelarge.info> wrote: > Guillaume Lelarge a écrit : > > > [...] > > > > The last one does what we want, but our ctlListView::AddColumn method's > handling of default values was buggy. The attached patch fixes this, and > changes pgTableCollection::ShowStatistics method to handle the new default > value (wxLIST_AUTOSIZE_USEHEADER). > > > > > > /me wishes he has a mail client that would tell him he forgot the "attached > patch" :-/ Yeah, me too :-) Patch looks good to my eyeballs - please apply. -- Dave Page EnterpriseDB UK: http://www.enterprisedb.com -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers |
Linear Mode
