SEO
vBulletin Search Engine Optimization
| |||||||
| Register | FAQ | Members List | Calendar | Search | Today's Posts | Mark Forums Read |
04-17-2008, 11:18 PM
| ||||
| ||||
 cleanup: remove MemSet() casts There were various locations in the code that were casting the first argument to MemSet() or occasionally memset() to a char *. This is not necessary, per C89: memset's first argument is a void * to begin with, and there is an implicit conversion between void * and any other pointer type. I also noticed a bit of unclear / inconsistent code in MemSet() itself: it's not obvious whether unary * or postfix ++ has higher precedence (the latter does), so I added some parentheses to make this clear. Barring any objections, I'll apply this to HEAD tomorrow. -Neil ---------------------------(end of broadcast)--------------------------- TIP 6: Have you searched our list archives? http://archives.postgresql.org      |
|
04-17-2008, 11:18 PM
| |||
| |||
| Re: cleanup: remove MemSet() casts Neil Conway wrote: > I also noticed a bit of unclear / inconsistent code in MemSet() itself: > it's not obvious whether unary * or postfix ++ has higher precedence > (the latter does), so I added some parentheses to make this clear. Okay, apparently I'm the only person who doesn't like code like this  Attached is a revised patch that doesn't make this change. -Neil ---------------------------(end of broadcast)--------------------------- TIP 2: you can get off all lists at once with the unregister command (send "unregister YourEmailAddressHere" to majordomo@postgresql.org) |
|
04-17-2008, 11:18 PM
| ||||
| ||||
| Re: cleanup: remove MemSet() casts Neil Conway wrote: > Okay, apparently I'm the only person who doesn't like code like this > Attached is a revised patch that doesn't make this change. Applied. -Neil ---------------------------(end of broadcast)--------------------------- TIP 9: the planner will ignore your desire to choose an index scan if your joining column's datatypes do not match |
Linear Mode
