SEO
vBulletin Search Engine Optimization
| |||||||
| Register | FAQ | Members List | Calendar | Search | Today's Posts | Mark Forums Read |
04-17-2008, 11:19 PM
| ||||
| ||||
 CSV consecutive newline bug I have just been alerted to a bug in the 8.0 handling of embedded newlines in CSV data. Basically it barfs on consecutive newlines. The attached patch for 8.0 appears to fix it. The bug isn't present in the HEAD branch, and I'm wondering if we should not backpatch the HEAD multiline patch rather than applying this. OTOH, applying this patch would probably be more in keeping with our conservative approach to changes to stable branches, I guess. cheers andrew ---------------------------(end of broadcast)--------------------------- TIP 5: Have you checked our extensive FAQ? http://www.postgresql.org/docs/faq      |
|
04-17-2008, 11:19 PM
| |||
| |||
| Re: CSV consecutive newline bug Andrew Dunstan wrote: > I have just been alerted to a bug in the 8.0 handling of embedded > newlines in CSV data. Basically it barfs on consecutive newlines. The > attached patch for 8.0 appears to fix it. The bug isn't present in the > HEAD branch, and I'm wondering if we should not backpatch the HEAD > multiline patch rather than applying this. Is there a particular reason to backport the larger patch? As a general rule I'm inclined to apply minimally-invasive fixes to stable branches, but I don't know the code in question, so perhaps there is some reason to make an exception in this case. Also, a regression test for this bug would be nice  -Neil ---------------------------(end of broadcast)--------------------------- TIP 7: don't forget to increase your free space map settings |
|
04-17-2008, 11:19 PM
| |||
| |||
| Re: CSV consecutive newline bug Neil Conway wrote: > Andrew Dunstan wrote: > >> I have just been alerted to a bug in the 8.0 handling of embedded >> newlines in CSV data. Basically it barfs on consecutive newlines. The >> attached patch for 8.0 appears to fix it. The bug isn't present in >> the HEAD branch, and I'm wondering if we should not backpatch the >> HEAD multiline patch rather than applying this. > > > Is there a particular reason to backport the larger patch? As a > general rule I'm inclined to apply minimally-invasive fixes to stable > branches, but I don't know the code in question, so perhaps there is > some reason to make an exception in this case. Well, if I'd known we were as far away from a release as we turned out to be at the time the original multiline limitation was discovered, I would have submitted a patch for inclusion in 8.0. Never mind - hindsight doesn't help much. Just go with the tiny patch. If anyone wants the later fix it's very easy to get, because it was the first patch applied after 8.0 branched. Just dropping in the later version of copy.c should work. > > Also, a regression test for this bug would be nice > > regression patch against 8.0 branch attached. cheers andrew ---------------------------(end of broadcast)--------------------------- TIP 7: don't forget to increase your free space map settings |
|
04-17-2008, 11:20 PM
| ||||
| ||||
| Re: CSV consecutive newline bug Andrew Dunstan wrote: > regression patch against 8.0 branch attached. The tiny patch has been applied to REL8_0_STABLE, and the regression test patch has been applied to both REL8_0_STABLE and HEAD. Thanks for the patches. -Neil ---------------------------(end of broadcast)--------------------------- TIP 3: if posting/reading through Usenet, please send an appropriate subscribe-nomail command to majordomo@postgresql.org so that your message can get through to the mailing list cleanly |
 |
« Re: lastval()
|
Micro doc patch »
| Thread Tools | |
| Display Modes | |
Linear Mode
|
|
All times are GMT. The time now is 12:42 AM.
