Unix Technical Forum

SEO

vBulletin Search Engine Optimization


Go Back   Unix Technical Forum > Database Server Software > PostgreSQL > Pgsql Patches

Register FAQ Members List Calendar Search Today's Posts Mark Forums Read
  #1 (permalink)  
Old 04-18-2008, 10:01 AM
Neil Conway
 
Posts: n/a
Default Enable integer datetimes by default

Attached is a patch that enables integer datetimes by default, per
recent discussion on -hackers. It makes "--enable-integer-datetimes" the
default, and documents the "--disable-integer-datetimes" configure
option as a means to get the previous default behavior.

Barring any objections, I'll apply this to HEAD tomorrow.

-Neil



---------------------------(end of broadcast)---------------------------
TIP 4: Have you searched our list archives?

http://archives.postgresql.org

Digg this Post!Add Post to del.icio.usBookmark Post in TechnoratiFurl this Post!
Reply With Quote
  #2 (permalink)  
Old 04-18-2008, 10:01 AM
Michael Glaesemann
 
Posts: n/a
Default Re: Enable integer datetimes by default


On May 5, 2007, at 22:28 , Neil Conway wrote:

> Attached is a patch that enables integer datetimes by default, per
> recent discussion on -hackers. It makes "--enable-integer-
> datetimes" the
> default, and documents the "--disable-integer-datetimes" configure
> option as a means to get the previous default behavior.


Would it make more sense to have phrase it in the positive sense?
i.e., --enable-floating-point-datetimes? I guess that's a bit longer,
but it says what you're doing, rather than what you're *not* doing.

Michael Glaesemann
grzm seespotcode net



---------------------------(end of broadcast)---------------------------
TIP 3: Have you checked our extensive FAQ?

http://www.postgresql.org/docs/faq

Digg this Post!Add Post to del.icio.usBookmark Post in TechnoratiFurl this Post!
Reply With Quote
  #3 (permalink)  
Old 04-18-2008, 10:01 AM
Neil Conway
 
Posts: n/a
Default Re: Enable integer datetimes by default

On Sat, 2007-05-05 at 22:49 -0500, Michael Glaesemann wrote:
> Would it make more sense to have phrase it in the positive sense?
> i.e., --enable-floating-point-datetimes? I guess that's a bit longer,
> but it says what you're doing, rather than what you're *not* doing.


I think the primary reason people will want to use FP-based datetimes is
because they can't use integer-based datetimes for compatibility reasons
(e.g. no OS support for 64-bit integers, or they need to remain
compatible with old applications). The situation is analogous to
--without-spinlocks: we could call that --enable-slow-locking or
something, but that would sound like we're enabling an additional
feature.

It would also mean there would be an implicit relationship between
"--enable-integer-datetimes" and "--enable-fp-datetimes" (at most one
can be true). IMHO it would be simpler to just keep a single boolean
variable ("integer datetimes enabled or not").

-Neil



---------------------------(end of broadcast)---------------------------
TIP 6: explain analyze is your friend

Digg this Post!Add Post to del.icio.usBookmark Post in TechnoratiFurl this Post!
Reply With Quote
  #4 (permalink)  
Old 04-18-2008, 10:01 AM
Andrew Dunstan
 
Posts: n/a
Default Re: Enable integer datetimes by default




Neil Conway wrote:
> Attached is a patch that enables integer datetimes by default, per
> recent discussion on -hackers. It makes "--enable-integer-datetimes" the
> default, and documents the "--disable-integer-datetimes" configure
> option as a means to get the previous default behavior.
>
> Barring any objections, I'll apply this to HEAD tomorrow.
>
>



I object to the short notice. I think we need to give people a chance to
adjust their configs, especially on the buildfarm, where those who have
currently simply removed the --enable-integer-datetimes setting will
need to adjust their configs.

Once there is agreement I think we should at the very least give those
people a few days to adjust.

cheers

andrew

---------------------------(end of broadcast)---------------------------
TIP 7: You can help support the PostgreSQL project by donating at

http://www.postgresql.org/about/donate

Digg this Post!Add Post to del.icio.usBookmark Post in TechnoratiFurl this Post!
Reply With Quote
  #5 (permalink)  
Old 04-18-2008, 10:01 AM
Neil Conway
 
Posts: n/a
Default Re: Enable integer datetimes by default

On Sun, 2007-06-05 at 00:20 -0400, Andrew Dunstan wrote:
> I object to the short notice. I think we need to give people a chance to
> adjust their configs


Sure, I can wait a few days (although if we're going to do this for 8.3,
we should do it promptly). On reflection, it might actually be wiser to
delay making this change until the beginning of the 8.4 cycle...

-Neil



---------------------------(end of broadcast)---------------------------
TIP 6: explain analyze is your friend

Digg this Post!Add Post to del.icio.usBookmark Post in TechnoratiFurl this Post!
Reply With Quote
  #6 (permalink)  
Old 04-18-2008, 10:01 AM
Andrew Dunstan
 
Posts: n/a
Default Re: Enable integer datetimes by default



Peter Eisentraut wrote:
> Andrew Dunstan wrote:
>
>> I think we need to give people a chance to
>> adjust their configs, especially on the buildfarm, where those who
>> have currently simply removed the --enable-integer-datetimes setting
>> will need to adjust their configs.
>>

>
> Why? They have previously been testing the default and now they would
> be testing a different default.
>
>


It is not the default for the buildfarm - the default config has
--enable-integer-datetimes. I would rather people have a chance to
adjust their configs so they keep testing the same config set,
regardless of whether or not it's the default.

cheers

andrew

---------------------------(end of broadcast)---------------------------
TIP 5: don't forget to increase your free space map settings

Digg this Post!Add Post to del.icio.usBookmark Post in TechnoratiFurl this Post!
Reply With Quote
  #7 (permalink)  
Old 04-18-2008, 10:01 AM
Peter Eisentraut
 
Posts: n/a
Default Re: Enable integer datetimes by default

Andrew Dunstan wrote:
> I think we need to give people a chance to
> adjust their configs, especially on the buildfarm, where those who
> have currently simply removed the --enable-integer-datetimes setting
> will need to adjust their configs.


Why? They have previously been testing the default and now they would
be testing a different default.

--
Peter Eisentraut
http://developer.postgresql.org/~petere/

---------------------------(end of broadcast)---------------------------
TIP 7: You can help support the PostgreSQL project by donating at

http://www.postgresql.org/about/donate

Digg this Post!Add Post to del.icio.usBookmark Post in TechnoratiFurl this Post!
Reply With Quote
  #8 (permalink)  
Old 04-18-2008, 10:01 AM
Andrew Dunstan
 
Posts: n/a
Default Re: Enable integer datetimes by default



Neil Conway wrote:
> On reflection, it might actually be wiser to
> delay making this change until the beginning of the 8.4 cycle...
>
>
>


I think that's probably true, but I can live with it either way as long
as there's enough notice.

cheers

andrew

---------------------------(end of broadcast)---------------------------
TIP 7: You can help support the PostgreSQL project by donating at

http://www.postgresql.org/about/donate

Digg this Post!Add Post to del.icio.usBookmark Post in TechnoratiFurl this Post!
Reply With Quote
  #9 (permalink)  
Old 04-18-2008, 10:01 AM
Tom Lane
 
Posts: n/a
Default Re: Enable integer datetimes by default

Neil Conway <neilc@samurai.com> writes:
> On Sun, 2007-06-05 at 00:20 -0400, Andrew Dunstan wrote:
>> I object to the short notice. I think we need to give people a chance to
>> adjust their configs


> Sure, I can wait a few days (although if we're going to do this for 8.3,
> we should do it promptly). On reflection, it might actually be wiser to
> delay making this change until the beginning of the 8.4 cycle...


+1 ... this had not been previously discussed for 8.3 and so it's
arguably too late in the cycle.

regards, tom lane

---------------------------(end of broadcast)---------------------------
TIP 2: Don't 'kill -9' the postmaster

Digg this Post!Add Post to del.icio.usBookmark Post in TechnoratiFurl this Post!
Reply With Quote
  #10 (permalink)  
Old 04-18-2008, 10:03 AM
Bruce Momjian
 
Posts: n/a
Default Re: Enable integer datetimes by default


Added to TODO:

* Have configure choose integer datetimes by default

http://archives.postgresql.org/pgsql...5/msg00046.php


---------------------------------------------------------------------------

Tom Lane wrote:
> Neil Conway <neilc@samurai.com> writes:
> > On Sun, 2007-06-05 at 00:20 -0400, Andrew Dunstan wrote:
> >> I object to the short notice. I think we need to give people a chance to
> >> adjust their configs

>
> > Sure, I can wait a few days (although if we're going to do this for 8.3,
> > we should do it promptly). On reflection, it might actually be wiser to
> > delay making this change until the beginning of the 8.4 cycle...

>
> +1 ... this had not been previously discussed for 8.3 and so it's
> arguably too late in the cycle.
>
> regards, tom lane
>
> ---------------------------(end of broadcast)---------------------------
> TIP 2: Don't 'kill -9' the postmaster


--
Bruce Momjian <bruce@momjian.us> http://momjian.us
EnterpriseDB http://www.enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

---------------------------(end of broadcast)---------------------------
TIP 7: You can help support the PostgreSQL project by donating at

http://www.postgresql.org/about/donate

Digg this Post!Add Post to del.icio.usBookmark Post in TechnoratiFurl this Post!
Reply With Quote
Reply


Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

vB code is On
Smilies are On
[IMG] code is On
HTML code is Off
Trackbacks are On
Pingbacks are On
Refbacks are On
Forum Jump


All times are GMT. The time now is 09:47 PM.


Powered by vBulletin® Version 3.6.5
Copyright ©2000 - 2008, Jelsoft Enterprises Ltd.
SEO by vBSEO 3.2.0
UnixAdminTalk.com

1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702