This is a discussion on Fix for _outAgg() within the Pgsql Patches forums, part of the PostgreSQL category; --> Attached is a patch which fixes an oversight in _outAgg(): the "grpColIdx" and "grpOperators" fields of the Agg struct ...
| |||||||
| FAQ | Members List | Calendar | Search | Today's Posts | Mark Forums Read |
| ||||
| Attached is a patch which fixes an oversight in _outAgg(): the "grpColIdx" and "grpOperators" fields of the Agg struct were not emitted by _outAgg(). I don't see any good reason to omit this information. Note that while the "grpOperators" field was added during the 8.3 devel cycle, the "grpColIdx" field has been around since '02 (without outfuncs support). So I can backpatch that portion of the patch to back branches if anyone feels strongly. -Neil ---------------------------(end of broadcast)--------------------------- TIP 5: don't forget to increase your free space map settings |
| |||
| Neil Conway <neilc@samurai.com> writes: > Attached is a patch which fixes an oversight in _outAgg(): the > "grpColIdx" and "grpOperators" fields of the Agg struct were not emitted > by _outAgg(). I don't see any good reason to omit this information. Hmm, I think that must be my fault, but I'm not sure how it got by me .... I'm usually pretty careful about adding outfuncs support when I add a node field. Patch looks good, please apply. > Note that while the "grpOperators" field was added during the 8.3 devel > cycle, the "grpColIdx" field has been around since '02 (without outfuncs > support). So I can backpatch that portion of the patch to back branches > if anyone feels strongly. Not worth backpatching --- the plan node output support is only of interest to hard-core hackers, who'd be working on current sources. regards, tom lane ---------------------------(end of broadcast)--------------------------- TIP 5: don't forget to increase your free space map settings |
| ||||
| On Tue, 2008-01-08 at 23:08 -0500, Tom Lane wrote: > Hmm, I think that must be my fault, but I'm not sure how it got by me > ... I'm usually pretty careful about adding outfuncs support when I add > a node field. Patch looks good, please apply. Applied to HEAD. -Neil ---------------------------(end of broadcast)--------------------------- TIP 6: explain analyze is your friend |