Unix Technical Forum

patch win32.mak of libpq

This is a discussion on patch win32.mak of libpq within the Pgsql Patches forums, part of the PostgreSQL category; --> Hi Magnus, and Dave. Sorry, I'm a somewhat late reaction... This is the present correspondence. However, VC6 does not ...


Go Back   Unix Technical Forum > Database Server Software > PostgreSQL > Pgsql Patches

FAQ Members List Calendar Search Today's Posts Mark Forums Read
  #1 (permalink)  
Old 04-18-2008, 11:26 AM
Hiroshi Saito
 
Posts: n/a
Default patch win32.mak of libpq

Hi Magnus, and Dave.

Sorry, I'm a somewhat late reaction... This is the present correspondence.
However, VC6 does not support SSAPI. Therefore, the next release makes
VC6 the outside of an object.

-- VC6
Microsoft (R) Program Maintenance Utility Version 6.00.9782.0
Copyright (C) Microsoft Corp 1988-1998. All rights reserved.

Building the Win32 static library...

Using default OpenSSL Include directory: C:\OpenSSL\include
Using default OpenSSL Library directory: C:\OpenSSL\lib\VC
Using default Kerberos Include directory: C:\kfw-2.6.5\inc
Using default Kerberos Library directory: C:\kfw-2.6.5\lib\i386
echo #define SYSCONFDIR "" > pg_config_paths.h
link.exe @C:\DOCUME~1\hiroshi\LOCALS~1\Temp\nma00120.
LINK : fatal error LNK1181: (snip japanese) "secur32.lib" (snip japanese)
NMAKE : fatal error U1077: 'link.exe' : (snip japanese) '0x49d'
Stop.
NMAKE : fatal error U1077: '"C:\Program Files\Microsoft Visual Studio\VC98\bin\N
MAKE.EXE"' : (snip japanese) '0x2'
Stop.

-- VC8
Microsoft(R) Program Maintenance Utility Version 8.00.50727.42
Copyright (C) Microsoft Corporation. All rights reserved.

Building the Win32 static library...

Using default OpenSSL Include directory: C:\OpenSSL\include
Using default OpenSSL Library directory: C:\OpenSSL\lib\VC
Using default Kerberos Include directory: C:\kfw-2.6.5\inc
Using default Kerberos Library directory: C:\kfw-2.6.5\lib\i386
link.exe @C:\DOCUME~1\hiroshi\LOCALS~1\Temp\nm969.tmp
(snip japanese) .\Release\libpqdll.lib (snip japanese) .\Release\libpqdll.exp (snip
japanese)
cd ..\..
echo All Win32 parts have been built!
All Win32 parts have been built!
--

If there is no objection. Let's close support of VC6.
What do you think?

Regards,
Hiroshi Saito


---------------------------(end of broadcast)---------------------------
TIP 3: Have you checked our extensive FAQ?

http://www.postgresql.org/docs/faq

Digg this Post!Add Post to del.icio.usBookmark Post in TechnoratiFurl this Post!
Reply With Quote
  #2 (permalink)  
Old 04-18-2008, 11:26 AM
Magnus Hagander
 
Posts: n/a
Default Re: patch win32.mak of libpq

On Wed, Jul 25, 2007 at 02:36:41PM +0900, Hiroshi Saito wrote:
> Hi Magnus, and Dave.
>
> Sorry, I'm a somewhat late reaction... This is the present correspondence.
> However, VC6 does not support SSAPI. Therefore, the next release makes
> VC6 the outside of an object.


I think VC6 should support it Ok. You probably just need to upgrade your
Platform SDK to a version that's for Windows 2000 or newer. I think VC6
shipws with the NT4 SDK by default. It looks like it' just missing
secur32.lib.

I have applied your patch, since it's used in either case. Thanks!

> If there is no objection. Let's close support of VC6.
> What do you think?


While I don't disagree in principle, if you can test it with a new Platfrom
SDK and see if that works there's no reason to close it (yet).

//Magnus

---------------------------(end of broadcast)---------------------------
TIP 5: don't forget to increase your free space map settings

Digg this Post!Add Post to del.icio.usBookmark Post in TechnoratiFurl this Post!
Reply With Quote
  #3 (permalink)  
Old 04-18-2008, 11:27 AM
Hiroshi Saito
 
Posts: n/a
Default Re: patch win32.mak of libpq

Hi Magnus.

Thanks!

From: "Magnus Hagander"


> On Wed, Jul 25, 2007 at 02:36:41PM +0900, Hiroshi Saito wrote:
>> Hi Magnus, and Dave.
>>
>> Sorry, I'm a somewhat late reaction... This is the present correspondence.
>> However, VC6 does not support SSAPI. Therefore, the next release makes
>> VC6 the outside of an object.

>
> I think VC6 should support it Ok. You probably just need to upgrade your
> Platform SDK to a version that's for Windows 2000 or newer. I think VC6
> shipws with the NT4 SDK by default. It looks like it' just missing
> secur32.lib.


Ahh yes. However, MS says.!
The last SDK that will work with VC 6.0 is the February 2003 Edition.
http://www.microsoft.com/msdownload/...sdk/sdkupdate/
this SDK is newer and does not support VC6.:-(

>
> I have applied your patch, since it's used in either case. Thanks!
>
>> If there is no objection. Let's close support of VC6.
>> What do you think?

>
> While I don't disagree in principle, if you can test it with a new Platfrom
> SDK and see if that works there's no reason to close it (yet).


It seems that it is difficult to get public although I have it.
Then, I feel that support is difficult.... I missed something?

Regards,
Hiroshi Saito

Regards,
Hiroshi Saito

---------------------------(end of broadcast)---------------------------
TIP 3: Have you checked our extensive FAQ?

http://www.postgresql.org/docs/faq

Digg this Post!Add Post to del.icio.usBookmark Post in TechnoratiFurl this Post!
Reply With Quote
  #4 (permalink)  
Old 04-18-2008, 11:27 AM
Magnus Hagander
 
Posts: n/a
Default Re: patch win32.mak of libpq

On Wed, Jul 25, 2007 at 10:30:29PM +0900, Hiroshi Saito wrote:
> >On Wed, Jul 25, 2007 at 02:36:41PM +0900, Hiroshi Saito wrote:
> >>Hi Magnus, and Dave.
> >>
> >>Sorry, I'm a somewhat late reaction... This is the present correspondence.
> >>However, VC6 does not support SSAPI. Therefore, the next release makes
> >>VC6 the outside of an object.

> >
> >I think VC6 should support it Ok. You probably just need to upgrade your
> >Platform SDK to a version that's for Windows 2000 or newer. I think VC6
> >shipws with the NT4 SDK by default. It looks like it' just missing
> >secur32.lib.

>
> Ahh yes. However, MS says.!
> The last SDK that will work with VC 6.0 is the February 2003 Edition.
> http://www.microsoft.com/msdownload/...sdk/sdkupdate/
> this SDK is newer and does not support VC6.:-(


Ooh. Wasn't aware of that :-( Now I see what you mean.

Ok. So there are actually two ways to go about it:
1) Discontinue support for MSVC6 and require MSVC8

2) Change it so that MSVC6 can still build libpq, just not with SSPI
support. This can be done by conditionally enabling ENABLE_SSPI, so it's
not that hard.

The question is, if we go with option 2, is it something that anybody
actually will *use*?

If I'm not mistaken, one of the original reasons we kept the win32.mak
method around after we had the "complete msvc build" was for the ODBC
folks. Are you saying that the ODBC guys are now happy with a MSVC8 build?

//Magnus

---------------------------(end of broadcast)---------------------------
TIP 3: Have you checked our extensive FAQ?

http://www.postgresql.org/docs/faq

Digg this Post!Add Post to del.icio.usBookmark Post in TechnoratiFurl this Post!
Reply With Quote
  #5 (permalink)  
Old 04-18-2008, 11:27 AM
Hiroshi Saito
 
Posts: n/a
Default Re: patch win32.mak of libpq

Hi.

From: "Magnus Hagander"


> On Wed, Jul 25, 2007 at 10:30:29PM +0900, Hiroshi Saito wrote:
>> >On Wed, Jul 25, 2007 at 02:36:41PM +0900, Hiroshi Saito wrote:
>> >>Hi Magnus, and Dave.
>> >>
>> >>Sorry, I'm a somewhat late reaction... This is the present correspondence.
>> >>However, VC6 does not support SSAPI. Therefore, the next release makes
>> >>VC6 the outside of an object.
>> >
>> >I think VC6 should support it Ok. You probably just need to upgrade your
>> >Platform SDK to a version that's for Windows 2000 or newer. I think VC6
>> >shipws with the NT4 SDK by default. It looks like it' just missing
>> >secur32.lib.

>>
>> Ahh yes. However, MS says.!
>> The last SDK that will work with VC 6.0 is the February 2003 Edition.
>> http://www.microsoft.com/msdownload/...sdk/sdkupdate/
>> this SDK is newer and does not support VC6.:-(

>
> Ooh. Wasn't aware of that :-( Now I see what you mean.


Yea, It is that there was nothing in public policy....

>
> Ok. So there are actually two ways to go about it:
> 1) Discontinue support for MSVC6 and require MSVC8
>
> 2) Change it so that MSVC6 can still build libpq, just not with SSPI
> support. This can be done by conditionally enabling ENABLE_SSPI, so it's
> not that hard.
>
> The question is, if we go with option 2, is it something that anybody
> actually will *use*?


I desire 1 as formal. However, It contains VC7.1 and VC8.
Moreover, libpq.dll can be used by the module of VC6.

>
> If I'm not mistaken, one of the original reasons we kept the win32.mak
> method around after we had the "complete msvc build" was for the ODBC
> folks. Are you saying that the ODBC guys are now happy with a MSVC8 build?


Yes, They are offered as comfortable environment. pgAdmin and that's right.!:-)
However, psqlODBC also contains legacy VC6. They will clear a problem by the
cause libpq.dll wire. Even if it may be adjusted from now on. probably.

Thanks!!

Regards,
Hiroshi Saito

---------------------------(end of broadcast)---------------------------
TIP 6: explain analyze is your friend

Digg this Post!Add Post to del.icio.usBookmark Post in TechnoratiFurl this Post!
Reply With Quote
  #6 (permalink)  
Old 04-18-2008, 11:27 AM
Magnus Hagander
 
Posts: n/a
Default Re: patch win32.mak of libpq

Hiroshi Saito wrote:
>>>> Ok. So there are actually two ways to go about it:
>>>> 1) Discontinue support for MSVC6 and require MSVC8
>>>>
>>>> 2) Change it so that MSVC6 can still build libpq, just not with SSPI
>>>> support. This can be done by conditionally enabling ENABLE_SSPI, so
>>>> it's
>>>> not that hard.
>>>>
>>>> The question is, if we go with option 2, is it something that anybody
>>>> actually will *use*?
>>>
>>> I desire 1 as formal. However, It contains VC7.1 and VC8.
>>> Moreover, libpq.dll can be used by the module of VC6.

>>
>> Is there any actual reason to keep VC7.1 support?

>
> It is still used and has sufficient function. Then, Inoue-san is
> developing in the environment.:-)
> The project file of VC7.1 differs from VC8 a little. However, nmake.exe
> absorbs it.
> for the reasons, we are maintaining win32.mak. but, project file offers
> the minimum function
> in simple. MSDTC is a reason for being somewhat more complicated than
> standard compile.


Ok. Just to be clear, do you need MSVC7.1 support, or do you need
win32.mak/nmake support? I realize they both work here, but if we
changed something else that needed MSVC8 but maintained the win32.mak
file, would that be enough?

Inoue-san, I'd be interested in knowing exactly what it is that is the
problem with MSVC8, if it's easy enough to outline?


>> 1) Does ODBC *require* a MSVC6 build libpq.dll?
>> 2) Can ODBC work with MVC8 built libpq, but ODBC is built with MSVC6?
>> 3) Can ODBC be built with MSVC8 and use the MSVC8 built libpq?
>>
>> It would be unfortunate if ODBC has to ship with a different set of
>> dependencies than libpq, but as long as they build with either VC6 or
>> VC8 that shouldn't happen.
>>
>> 1 above would be really bad, but I'm 99% sure that's not so, since I've
>> actually tested SSPI auth with such a libpq.
>>
>> IMO, the best option would be 3, but I don't know enough about the ODBC
>> driver to comment on there. I'll CC this to the odbc list so we can get
>> more input from other people there.

>
> I'm sure that 3 is sufficient. I will begin the preparation.
> Of course, if there is a problem, though it will be corrected.


Great. Let me know if you need any assistance.


//Magnus


---------------------------(end of broadcast)---------------------------
TIP 3: Have you checked our extensive FAQ?

http://www.postgresql.org/docs/faq

Digg this Post!Add Post to del.icio.usBookmark Post in TechnoratiFurl this Post!
Reply With Quote
  #7 (permalink)  
Old 04-18-2008, 11:28 AM
Magnus Hagander
 
Posts: n/a
Default Re: patch win32.mak of libpq

On Fri, Jul 27, 2007 at 10:01:06PM +0200, Magnus Hagander wrote:
> Hiroshi Saito wrote:
> >>>> Ok. So there are actually two ways to go about it:
> >>>> 1) Discontinue support for MSVC6 and require MSVC8
> >>>>
> >>>> 2) Change it so that MSVC6 can still build libpq, just not with SSPI
> >>>> support. This can be done by conditionally enabling ENABLE_SSPI, so
> >>>> it's
> >>>> not that hard.
> >>>>
> >>>> The question is, if we go with option 2, is it something that anybody
> >>>> actually will *use*?
> >>>
> >>> I desire 1 as formal. However, It contains VC7.1 and VC8.
> >>> Moreover, libpq.dll can be used by the module of VC6.
> >>
> >> Is there any actual reason to keep VC7.1 support?

> >
> > It is still used and has sufficient function. Then, Inoue-san is
> > developing in the environment.:-)
> > The project file of VC7.1 differs from VC8 a little. However, nmake.exe
> > absorbs it.
> > for the reasons, we are maintaining win32.mak. but, project file offers
> > the minimum function
> > in simple. MSDTC is a reason for being somewhat more complicated than
> > standard compile.

>
> Ok. Just to be clear, do you need MSVC7.1 support, or do you need
> win32.mak/nmake support? I realize they both work here, but if we
> changed something else that needed MSVC8 but maintained the win32.mak
> file, would that be enough?


Since I've had no further feedback, I've applied a patch that changes the
list of supported MSVC versions to 7.1-8.0, but keeping the win32.mak
files.

//Magnus

---------------------------(end of broadcast)---------------------------
TIP 6: explain analyze is your friend

Digg this Post!Add Post to del.icio.usBookmark Post in TechnoratiFurl this Post!
Reply With Quote
  #8 (permalink)  
Old 04-18-2008, 11:28 AM
Hiroshi Saito
 
Posts: n/a
Default Re: [ODBC] patch win32.mak of libpq

Hi Magnus.

I'm sorry lateness of a reaction..
Thanks!

P.S)
Inoue-san is busy and worsens condition.

Regards,
Hiroshi Saito

>> Ok. Just to be clear, do you need MSVC7.1 support, or do you need
>> win32.mak/nmake support? I realize they both work here, but if we
>> changed something else that needed MSVC8 but maintained the win32.mak
>> file, would that be enough?

>
> Since I've had no further feedback, I've applied a patch that changes the
> list of supported MSVC versions to 7.1-8.0, but keeping the win32.mak
> files.
>
> //Magnus



---------------------------(end of broadcast)---------------------------
TIP 2: Don't 'kill -9' the postmaster

Digg this Post!Add Post to del.icio.usBookmark Post in TechnoratiFurl this Post!
Reply With Quote
Reply


Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

vB code is On
Smilies are On
[IMG] code is On
HTML code is Off
Trackbacks are On
Pingbacks are On
Refbacks are On
Forum Jump


All times are GMT. The time now is 04:49 PM.


Powered by vBulletin® Version 3.6.5
Copyright ©2000 - 2008, Jelsoft Enterprises Ltd.
SEO by vBSEO 3.2.0
www.UnixAdminTalk.com