SEO

This patch reduces the size of the message header used by statistics
collector messages, per recent discussion. This actually required quite
a few changes -- for example, "databaseid != InvalidOid" was used to
check whether a slot in the backend entry table was initialized, but
that no longer works since the slot might be initialized prior to
receiving the BESTART message which contains the database id. We know
use procpid > 0 to indicate that a slot is non-empty.

Other changes:

- various comment improvements and cleanups

- there's no need to zero-out the entire activity buffer in
pgstat_add_backend(), we can just set activity[0] to '\0'.

- remove the counting of the # of connections to a database; this was
not used anywhere

One change in behavior I wasn't sure about: previously, the code would
create a hash table entry for a database as soon as any message was
received whose header referenced that database. Now, we only create hash
table entries as needed (so for example BESTART won't create a hash
table entry, since it doesn't need to access the per-db hash table). Is
it important that we retain the previous behavior? (It would be easy
enough to do by just calling pgstat_get_db_entry() when processing a
BESTART.)

Barring any objections I'll apply this to HEAD tomorrow.

-Neil


---------------------------(end of broadcast)---------------------------
TIP 5: Have you checked our extensive FAQ?

http://www.postgresql.org/docs/faq

Neil Conway wrote:
> This patch reduces the size of the message header used by statistics
> collector messages, per recent discussion.

Applied.

-Neil

---------------------------(end of broadcast)---------------------------
TIP 2: you can get off all lists at once with the unregister command
(send "unregister YourEmailAddressHere" to majordomo@postgresql.org)