SEO

#1 (**permalink**) 04-17-2008, 11:00 PM

On Tue, 2005-01-25 at 01:13 -0500, Kris Jurka wrote:
> The attached patch implements the soundex difference function which
> compares two strings' soundex values for similarity.

*** 19,24 ****
--- 19,28 ----
AS 'MODULE_PATHNAME', 'soundex'
LANGUAGE 'C';

+ CREATE FUNCTION difference(text,text) RETURNS int
+ AS 'MODULE_PATHNAME', 'difference'
+ LANGUAGE 'C';
+

This should be immutable, right?

-Neil

---------------------------(end of broadcast)---------------------------
TIP 7: don't forget to increase your free space map settings

#2 (**permalink**) 04-17-2008, 11:00 PM

On Tue, 2005-01-25 at 02:26 -0500, Kris Jurka wrote:
> Yes, it should, and even more importantly strict because it crashes when
> called with null inputs. I copied this off the adjacent entry without
> thinking about it. So currently SELECT text_soundex(NULL); crashes the
> server.

Ah, good catch. I remember checking all the builtin functions for
crashes on NULL input; it would be worth doing the same for contrib/.

Barring any objections, I'll apply the full patch to HEAD and the crash
fix to REL8_0_STABLE and REL7_4_STABLE tomorrow.

-Neil

---------------------------(end of broadcast)---------------------------
TIP 2: you can get off all lists at once with the unregister command
(send "unregister YourEmailAddressHere" to majordomo@postgresql.org)

#3 (**permalink**) 04-17-2008, 11:00 PM

Kris Jurka wrote:
> I've attached two new patches. One revising my original patch to
> make the function creations consistent and the other to just fix the
> problem in the existing code (which should be backported as far as people
> would like to).

Full patch applied to HEAD, fix for STRICT applied to 8.0, 7.4, 7.3 and 7.2

Thanks for the patches.

-Neil

---------------------------(end of broadcast)---------------------------
TIP 2: you can get off all lists at once with the unregister command
(send "unregister YourEmailAddressHere" to majordomo@postgresql.org)

Thread Tools
Show Printable Version Email this Page
Display Modes
Linear Mode Switch to Hybrid Mode Switch to Threaded Mode

SEO

Re: add soundex difference function to