Unix Technical Forum

Re: BUG #2600: dblink compile with SSL missing libraries

This is a discussion on Re: BUG #2600: dblink compile with SSL missing libraries within the Pgsql Patches forums, part of the PostgreSQL category; --> peter_e@gmx.net (Peter Eisentraut) writes: > Am Mittwoch, 30. August 2006 22:57 schrieb Chris Browne: >> I also seem to ...


Go Back   Unix Technical Forum > Database Server Software > PostgreSQL > Pgsql Patches

FAQ Members List Calendar Search Today's Posts Mark Forums Read
  #1 (permalink)  
Old 04-18-2008, 09:58 AM
Chris Browne
 
Posts: n/a
Default Re: BUG #2600: dblink compile with SSL missing libraries

peter_e@gmx.net (Peter Eisentraut) writes:
> Am Mittwoch, 30. August 2006 22:57 schrieb Chris Browne:
>> I also seem to recall, in past discussions about "library matters,"
>> that AIX is more sticky about requiring that libraries be named
>> expressly.

>
> ecpglib has
>
> SHLIB_LINK = -L../pgtypeslib -lpgtypes $(libpq) \
> $(filter -lintl -lssl -lcrypto -lkrb5 -lcrypt -lm, $(LIBS))
> $(PTHREAD_LIBS)
>
> ifeq ($(PORTNAME), win32)
> # Link to shfolder.dll instead of shell32.dll
> SHLIB_LINK += -lshfolder
> endif
>
> Presumably the same would be necessary everywhere else libpq is used.


I replaced:
SHLIB_LINK = $(libpq)

with
SHLIB_LINK = $(libpq) $(LIBS)

which allowed the compile to get through this.

If I add that very same line:
SHLIB_LINK = $(libpq) $(LIBS)

to contrib/sslinfo/Makefile, it now survives the compile, as well as
successfully running through, for contrib, "make install" and "make
installcheck".
--
"cbbrowne","@","cbbrowne.com"
http://linuxfinances.info/info/unix.html
Do you know where your towel is?
Digg this Post!Add Post to del.icio.usBookmark Post in TechnoratiFurl this Post!
Reply With Quote
  #2 (permalink)  
Old 04-18-2008, 09:58 AM
Chris Browne
 
Posts: n/a
Default Re: BUG #2600: dblink compile with SSL missing libraries

The change Tom made to contrib/sshinfo/Makefile to support Darwin,
adding in $(LIBS), fixed my problem with that contrib module on AIX.

I still need the following, on AIX:

================================================== =================
RCS file: /projects/cvsroot/pgsql/contrib/dblink/Makefile,v
retrieving revision 1.11
diff -u -r1.11 Makefile
--- Makefile 27 Feb 2006 12:54:38 -0000 1.11
+++ Makefile 6 Sep 2006 19:48:23 -0000
@@ -3,7 +3,7 @@
MODULE_big = dblink
PG_CPPFLAGS = -I$(libpq_srcdir)
OBJS = dblink.o
-SHLIB_LINK = $(libpq)
+SHLIB_LINK = $(libpq) $(LIBS)

DATA_built = dblink.sql
DATA = uninstall_dblink.sql
--
(reverse (concatenate 'string "moc.enworbbc" "@" "enworbbc"))
http://linuxdatabases.info/info/nonrdbms.html
"Fashion is a form of ugliness so intolerable that we have to alter it
every six months." -- Oscar Wilde
Digg this Post!Add Post to del.icio.usBookmark Post in TechnoratiFurl this Post!
Reply With Quote
  #3 (permalink)  
Old 04-18-2008, 09:58 AM
Tom Lane
 
Posts: n/a
Default Re: BUG #2600: dblink compile with SSL missing libraries

Chris Browne <cbbrowne@acm.org> writes:
> I still need the following, on AIX:


> -SHLIB_LINK = $(libpq)
> +SHLIB_LINK = $(libpq) $(LIBS)


No you don't --- see recent warthog complaint. We have to filter LIBS
down to just the minimum.

regards, tom lane

---------------------------(end of broadcast)---------------------------
TIP 1: if posting/reading through Usenet, please send an appropriate
subscribe-nomail command to majordomo@postgresql.org so that your
message can get through to the mailing list cleanly

Digg this Post!Add Post to del.icio.usBookmark Post in TechnoratiFurl this Post!
Reply With Quote
  #4 (permalink)  
Old 04-18-2008, 09:59 AM
Chris Browne
 
Posts: n/a
Default Re: BUG #2600: dblink compile with SSL missing libraries

tgl@sss.pgh.pa.us (Tom Lane) writes:
> Chris Browne <cbbrowne@acm.org> writes:
>> I still need the following, on AIX:

>
>> -SHLIB_LINK = $(libpq)
>> +SHLIB_LINK = $(libpq) $(LIBS)

>
> No you don't --- see recent warthog complaint. We have to filter LIBS
> down to just the minimum.


I'm at a loss, then.

- If LIBS is being filtered to the minimum, then shouldn't it be
appropriate to add it in here?

- There isn't any variable other than LIBS that *does* get bound to
include -lssl and -lcrypto

- Do we need to add an additional LIBSSL, spattered widely through
makefiles, which sometimes gets linked in?

- Or do we need some custom DBLINKLIBS, defined in configure, that is
only used for dblink?
--
(reverse (concatenate 'string "moc.enworbbc" "@" "enworbbc"))
http://www3.sympatico.ca/cbbrowne/languages.html
QT adds to a Linux distribution a level of licencing complexity that
nullifies one of the major virtues of Linux: no licencing complexity.
-- <jedi@dementia.mishnet>
Digg this Post!Add Post to del.icio.usBookmark Post in TechnoratiFurl this Post!
Reply With Quote
  #5 (permalink)  
Old 04-18-2008, 09:59 AM
Tom Lane
 
Posts: n/a
Default Re: BUG #2600: dblink compile with SSL missing libraries

Chris Browne <cbbrowne@acm.org> writes:
> tgl@sss.pgh.pa.us (Tom Lane) writes:
>> No you don't --- see recent warthog complaint. We have to filter LIBS
>> down to just the minimum.


> I'm at a loss, then.


> - If LIBS is being filtered to the minimum, then shouldn't it be
> appropriate to add it in here?


No, LIBS isn't filtered at all. See my recent commit to sslinfo's
Makefile --- I blew it just like this, you should learn from my mistake.

regards, tom lane

---------------------------(end of broadcast)---------------------------
TIP 3: Have you checked our extensive FAQ?

http://www.postgresql.org/docs/faq

Digg this Post!Add Post to del.icio.usBookmark Post in TechnoratiFurl this Post!
Reply With Quote
  #6 (permalink)  
Old 04-18-2008, 09:59 AM
Chris Browne
 
Posts: n/a
Default Re: BUG #2600: dblink compile with SSL missing libraries

tgl@sss.pgh.pa.us (Tom Lane) writes:
> Chris Browne <cbbrowne@acm.org> writes:
>> tgl@sss.pgh.pa.us (Tom Lane) writes:
>>> No you don't --- see recent warthog complaint. We have to filter LIBS
>>> down to just the minimum.

>
>> I'm at a loss, then.

>
>> - If LIBS is being filtered to the minimum, then shouldn't it be
>> appropriate to add it in here?

>
> No, LIBS isn't filtered at all. See my recent commit to sslinfo's
> Makefile --- I blew it just like this, you should learn from my mistake.


OK, the very same change as your recent change to
contrib/sslinfo/Makefile works out fine for contrib/dblink/Makefile.
That allows a buildfarm run to go through perfectly.

I suspect that both Makefiles also need to "filter in" -lgettext or
something similar; see bug #2608, which shows off much the same
problem surrounding NLS support. (I'm happy to see that someone's
running xlC on AIX 5.3, by the way... I should be getting a copy Real
Soon Now, but it may not be soon enough to be helpful :-( )
--
output = reverse("ofni.secnanifxunil" "@" "enworbbc")
http://linuxdatabases.info/info/multiplexor.html
"If God meant us to be vegetarians why'd He make cows out of meat?"
-- seen on a bumper sticker
Digg this Post!Add Post to del.icio.usBookmark Post in TechnoratiFurl this Post!
Reply With Quote
  #7 (permalink)  
Old 04-18-2008, 09:59 AM
Chris Browne
 
Posts: n/a
Default Re: BUG #2600: dblink compile with SSL missing libraries

tgl@sss.pgh.pa.us (Tom Lane) writes:
> Chris Browne <cbbrowne@acm.org> writes:
>> tgl@sss.pgh.pa.us (Tom Lane) writes:
>>> No you don't --- see recent warthog complaint. We have to filter LIBS
>>> down to just the minimum.

>
>> I'm at a loss, then.

>
>> - If LIBS is being filtered to the minimum, then shouldn't it be
>> appropriate to add it in here?

>
> No, LIBS isn't filtered at all. See my recent commit to sslinfo's
> Makefile --- I blew it just like this, you should learn from my mistake.
>


Here is a patch (context diff) for this...

cvs diff: Diffing .
Index: Makefile
================================================== =================
RCS file: /projects/cvsroot/pgsql/contrib/dblink/Makefile,v
retrieving revision 1.11
diff -c -u -r1.11 Makefile
cvs diff: conflicting specifications of output style
--- Makefile 27 Feb 2006 12:54:38 -0000 1.11
+++ Makefile 8 Sep 2006 18:35:59 -0000
@@ -20,3 +20,5 @@
include $(top_builddir)/src/Makefile.global
include $(top_srcdir)/contrib/contrib-global.mk
endif
+
+SHLIB_LINK += $(filter -lssl -lcrypto -lssleay32 -leay32, $(LIBS))

--
select 'cbbrowne' || '@' || 'cbbrowne.com';
http://cbbrowne.com/info/sgml.html
Willie was a Chemist,
But Willie is no more,
What Willie thought was H20
Was H2SO4.
Digg this Post!Add Post to del.icio.usBookmark Post in TechnoratiFurl this Post!
Reply With Quote
Reply


Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

vB code is On
Smilies are On
[IMG] code is On
HTML code is Off
Trackbacks are On
Pingbacks are On
Refbacks are On
Forum Jump


All times are GMT. The time now is 05:20 PM.


Powered by vBulletin® Version 3.6.5
Copyright ©2000 - 2008, Jelsoft Enterprises Ltd.
SEO by vBSEO 3.2.0
www.UnixAdminTalk.com