Magnus Hagander wrote:
>>
>> You seem to have misunderstood what I am suggesting. Of course we should
>> document use of buildenv.pl in addition to the hacky fix to the .bat
>> files. The hack is the part that would be invisible. The docs would be
>> visible and contain what would be our ongoing practice.
>>
>
> Correct, I was misunderstanding it :-)
>
> I still can't say I like that hack though. I'd rather document that you
> have to do it in the .bat file for docs + gui build.
>
> But it's better than what I thought you were proposing :-)
>
>
>

Well, I honestly think we can live with it for one cycle. As soon as 8.4
opens I'll get to work converting these .bat files to pure one line
wrappers.

Meanwhile, here's the proposed patch. If you want something else you'll
have to do it.

I don't know how many people regularly build on Windows other than you,
me and Dave.

cheers

andrew


---------------------------(end of broadcast)---------------------------
TIP 3: Have you checked our extensive FAQ?

http://www.postgresql.org/docs/faq

On Sun, Dec 09, 2007 at 02:40:37PM -0500, Andrew Dunstan wrote:
>
>
> Magnus Hagander wrote:
> >>
> >>You seem to have misunderstood what I am suggesting. Of course we should
> >>document use of buildenv.pl in addition to the hacky fix to the .bat
> >>files. The hack is the part that would be invisible. The docs would be
> >>visible and contain what would be our ongoing practice.
> >>
> >
> >Correct, I was misunderstanding it :-)
> >
> >I still can't say I like that hack though. I'd rather document that you
> >have to do it in the .bat file for docs + gui build.
> >
> >But it's better than what I thought you were proposing :-)
> >
> >
> >
>
> Well, I honestly think we can live with it for one cycle. As soon as 8.4
> opens I'll get to work converting these .bat files to pure one line
> wrappers.

Ok. We obviously don't agree on what to do here, so let's open it up for somebody
else to comment on what they think is best.

My take is document the fact that you have to do it twice. Andrews is this
patch.

> Meanwhile, here's the proposed patch. If you want something else you'll
> have to do it.
>
> I don't know how many people regularly build on Windows other than you,
> me and Dave.

I know a couple of others. But - it was Dave that got bitten by this thing
first, which is when I noticed it and brought it up :-P

//Magnus

---------------------------(end of broadcast)---------------------------
TIP 3: Have you checked our extensive FAQ?

http://www.postgresql.org/docs/faq

Magnus Hagander wrote:
>>>
>>>
>>>
>> Well, I honestly think we can live with it for one cycle. As soon as 8.4
>> opens I'll get to work converting these .bat files to pure one line
>> wrappers.
>>
>
> Ok. We obviously don't agree on what to do here, so let's open it up for somebody
> else to comment on what they think is best.
>
> My take is document the fact that you have to do it twice. Andrews is this
> patch.
>
>


Nobody else seems to care :-)

My reasoning is that I don't want to make people change their setups in
future. The should just be able to set up buildenv.pl now and continue
to use it even when I've fixed the .bat files next release.

Writing and calling a temp .bat file might be yucky - having to keep two
environment files is a lot more yucky, IMNSHO, and we shouldn't make
people do it.

cheers

andrew

---------------------------(end of broadcast)---------------------------
TIP 9: In versions below 8.0, the planner will ignore your desire to
choose an index scan if your joining column's datatypes do not
match

Andrew Dunstan wrote:
> Writing and calling a temp .bat file might be yucky - having to keep two
> environment files is a lot more yucky, IMNSHO, and we shouldn't make
> people do it.

+1

/D

---------------------------(end of broadcast)---------------------------
TIP 9: In versions below 8.0, the planner will ignore your desire to
choose an index scan if your joining column's datatypes do not
match

On Fri, Dec 14, 2007 at 03:39:14PM +0000, Dave Page wrote:
> Andrew Dunstan wrote:
> > Writing and calling a temp .bat file might be yucky - having to keep two
> > environment files is a lot more yucky, IMNSHO, and we shouldn't make
> > people do it.
>
> +1

Ok, I guess I'm outvoted ;-) I don't care *that* much about it, so let's do
it your way.

You need help testing that patch further, or do you consider it ready for
application? If so, go.

//Magnus

---------------------------(end of broadcast)---------------------------
TIP 3: Have you checked our extensive FAQ?

http://www.postgresql.org/docs/faq

Magnus Hagander wrote:
> On Fri, Dec 14, 2007 at 03:39:14PM +0000, Dave Page wrote:
>
>> Andrew Dunstan wrote:
>>
>>> Writing and calling a temp .bat file might be yucky - having to keep two
>>> environment files is a lot more yucky, IMNSHO, and we shouldn't make
>>> people do it.
>>>
>> +1
>>
>
> Ok, I guess I'm outvoted ;-) I don't care *that* much about it, so let's do
> it your way.
>
> You need help testing that patch further, or do you consider it ready for
> application? If so, go.
>
>
>

Yes, please do test it - I don't use buildenv.* at all normally, as then
buildfarm client takes care of its own environment, and that's what I
usually use to build on Windows.


cheers

andrew.

---------------------------(end of broadcast)---------------------------
TIP 7: You can help support the PostgreSQL project by donating at

http://www.postgresql.org/about/donate

On Fri, Dec 14, 2007 at 10:47:02AM -0500, Andrew Dunstan wrote:
>
>
> Magnus Hagander wrote:
> >On Fri, Dec 14, 2007 at 03:39:14PM +0000, Dave Page wrote:
> >
> >>Andrew Dunstan wrote:
> >>
> >>>Writing and calling a temp .bat file might be yucky - having to keep two
> >>>environment files is a lot more yucky, IMNSHO, and we shouldn't make
> >>>people do it.
> >>>
> >>+1
> >>
> >
> >Ok, I guess I'm outvoted ;-) I don't care *that* much about it, so let's do
> >it your way.
> >
> >You need help testing that patch further, or do you consider it ready for
> >application? If so, go.
> >
> >
> >
>
> Yes, please do test it - I don't use buildenv.* at all normally, as then
> buildfarm client takes care of its own environment, and that's what I
> usually use to build on Windows.

It works in my two standalone environments (win32 and win64 machine),
so I've applied the patch now to get full buildfarm testing.

//Magnus

---------------------------(end of broadcast)---------------------------
TIP 2: Don't 'kill -9' the postmaster