Unix Technical Forum

Re: Changes for AIX buildfarm

This is a discussion on Re: Changes for AIX buildfarm within the Pgsql Patches forums, part of the PostgreSQL category; --> "Rocco Altier" <RoccoA@Routescape.com> writes: > Need to have these patches applied to get AIX 5.2 to build as a ...


Go Back   Unix Technical Forum > Database Server Software > PostgreSQL > Pgsql Patches

FAQ Members List Calendar Search Today's Posts Mark Forums Read
  #1 (permalink)  
Old 04-17-2008, 11:41 PM
Tom Lane
 
Posts: n/a
Default Re: Changes for AIX buildfarm

"Rocco Altier" <RoccoA@Routescape.com> writes:
> Need to have these patches applied to get AIX 5.2 to build as a member
> of the buildfarm.


Er, which buildfarm report is prompting this?

> There are C++ style comments in contrib/pgcrypto which is giving cc
> problems.


Definitely contrary to project policy, will fix.

regards, tom lane

---------------------------(end of broadcast)---------------------------
TIP 6: explain analyze is your friend

Digg this Post!Add Post to del.icio.usBookmark Post in TechnoratiFurl this Post!
Reply With Quote
  #2 (permalink)  
Old 04-17-2008, 11:41 PM
Andrew Dunstan
 
Posts: n/a
Default Re: Changes for AIX buildfarm



Tom Lane wrote:

>"Rocco Altier" <RoccoA@Routescape.com> writes:
>
>
>>Need to have these patches applied to get AIX 5.2 to build as a member
>>of the buildfarm.
>>
>>

>
>Er, which buildfarm report is prompting this?
>
>
>


Rocco is probably doing what I normally ask, which is to get builds
working before starting to upload results to the buildfarm server (a
request which is more honored in the breach than the observance).

cheers

andrew

---------------------------(end of broadcast)---------------------------
TIP 2: Don't 'kill -9' the postmaster

Digg this Post!Add Post to del.icio.usBookmark Post in TechnoratiFurl this Post!
Reply With Quote
  #3 (permalink)  
Old 04-17-2008, 11:41 PM
Tom Lane
 
Posts: n/a
Default Re: Changes for AIX buildfarm

Andrew Dunstan <andrew@dunslane.net> writes:
> Tom Lane wrote:
>> Er, which buildfarm report is prompting this?


> Rocco is probably doing what I normally ask, which is to get builds
> working before starting to upload results to the buildfarm server (a
> request which is more honored in the breach than the observance).


Fair enough. But I'm concerned about the proposed patch because it
seems to revert a deliberate change made some time ago:

http://developer.postgresql.org/cvsw....shlib#rev1.65
http://archives.postgresql.org/pgsql...0/msg00054.php

so I think we need more eyeballs on the problem before deciding this is
a good fix.

regards, tom lane

---------------------------(end of broadcast)---------------------------
TIP 9: In versions below 8.0, the planner will ignore your desire to
choose an index scan if your joining column's datatypes do not
match

Digg this Post!Add Post to del.icio.usBookmark Post in TechnoratiFurl this Post!
Reply With Quote
  #4 (permalink)  
Old 04-17-2008, 11:41 PM
Tom Lane
 
Posts: n/a
Default Re: Changes for AIX buildfarm

Marko Kreen <marko@l-t.ee> writes:
> On Mon, Jul 18, 2005 at 12:32:21PM -0400, Tom Lane wrote:
>> Definitely contrary to project policy, will fix.


> Don't, they are fixed in "small cleanups" patch that I sent.


Too late, already committed ;-)

I will do something to clean up the mess...

regards, tom lane

---------------------------(end of broadcast)---------------------------
TIP 5: don't forget to increase your free space map settings

Digg this Post!Add Post to del.icio.usBookmark Post in TechnoratiFurl this Post!
Reply With Quote
  #5 (permalink)  
Old 04-17-2008, 11:41 PM
Marko Kreen
 
Posts: n/a
Default Re: Changes for AIX buildfarm

On Mon, Jul 18, 2005 at 12:32:21PM -0400, Tom Lane wrote:
> "Rocco Altier" <RoccoA@Routescape.com> writes:
> > There are C++ style comments in contrib/pgcrypto which is giving cc
> > problems.

>
> Definitely contrary to project policy, will fix.


Don't, they are fixed in "small cleanups" patch that I sent.

--
marko


---------------------------(end of broadcast)---------------------------
TIP 1: if posting/reading through Usenet, please send an appropriate
subscribe-nomail command to majordomo@postgresql.org so that your
message can get through to the mailing list cleanly

Digg this Post!Add Post to del.icio.usBookmark Post in TechnoratiFurl this Post!
Reply With Quote
  #6 (permalink)  
Old 04-17-2008, 11:42 PM
Peter Eisentraut
 
Posts: n/a
Default Re: Changes for AIX buildfarm

Tom Lane wrote:
> Fair enough. But I'm concerned about the proposed patch because it
> seems to revert a deliberate change made some time ago:
>
> http://developer.postgresql.org/cvsw...kefile.shlib#r
>ev1.65
> http://archives.postgresql.org/pgsql...0/msg00054.php
>
> so I think we need more eyeballs on the problem before deciding this
> is a good fix.


A potentially more correct solution would be to set SHLIB_LINK in the
makefiles of the affected modules only. Certainly we don't want to
link with all libraries all the time.

--
Peter Eisentraut
http://developer.postgresql.org/~petere/

---------------------------(end of broadcast)---------------------------
TIP 9: In versions below 8.0, the planner will ignore your desire to
choose an index scan if your joining column's datatypes do not
match

Digg this Post!Add Post to del.icio.usBookmark Post in TechnoratiFurl this Post!
Reply With Quote
Reply


Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

vB code is On
Smilies are On
[IMG] code is On
HTML code is Off
Trackbacks are On
Pingbacks are On
Refbacks are On
Forum Jump


All times are GMT. The time now is 10:54 AM.


Powered by vBulletin® Version 3.6.5
Copyright ©2000 - 2008, Jelsoft Enterprises Ltd.
SEO by vBSEO 3.2.0
www.UnixAdminTalk.com