Unix Technical Forum

Re: contrib/spi makefile inconsistency

This is a discussion on Re: contrib/spi makefile inconsistency within the Pgsql Patches forums, part of the PostgreSQL category; --> Magnus Hagander <magnus@hagander.net> writes: > contrib/spi has a Makefile that uses $(addsuffix) makefile rules for > DATA_built and DOCS. ...


Go Back   Unix Technical Forum > Database Server Software > PostgreSQL > Pgsql Patches

FAQ Members List Calendar Search Today's Posts Mark Forums Read
  #1 (permalink)  
Old 04-18-2008, 09:44 AM
Tom Lane
 
Posts: n/a
Default Re: contrib/spi makefile inconsistency

Magnus Hagander <magnus@hagander.net> writes:
> contrib/spi has a Makefile that uses $(addsuffix) makefile rules for
> DATA_built and DOCS. It's the only Makefile in contrib that does it.
> I would like to change that to actually listing the modules instead.


This seems like a definite regression in terms of writing the makefiles.
I'm not very happy about it --- just how much complexity are you saving
in the msvc support? And have you looked at the other places where
addsuffix is already used? (It looks like many of the contrib modules
rely on pgxs.mk's usages of addsuffix...)

regards, tom lane

---------------------------(end of broadcast)---------------------------
TIP 7: You can help support the PostgreSQL project by donating at

http://www.postgresql.org/about/donate

Digg this Post!Add Post to del.icio.usBookmark Post in TechnoratiFurl this Post!
Reply With Quote
Reply


Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

vB code is On
Smilies are On
[IMG] code is On
HTML code is Off
Trackbacks are On
Pingbacks are On
Refbacks are On
Forum Jump


All times are GMT. The time now is 02:00 AM.


Powered by vBulletin® Version 3.6.5
Copyright ©2000 - 2008, Jelsoft Enterprises Ltd.
SEO by vBSEO 3.2.0
www.UnixAdminTalk.com