This is a discussion on Re: Current enums patch within the Pgsql Patches forums, part of the PostgreSQL category; --> > Looks like we need to check the length on type creation > too. > > I'll fix later ...
| |||||||
| Register | FAQ | Members List | Calendar | Search | Today's Posts | Mark Forums Read |
| ||||
| > Looks like we need to check the length on type creation > too. > > I'll fix later if not beaten to it. It works for me (ie fails with an appropriate error) locally on Linux FC6 x86-64. Perhaps this platform initializes memory to zero on allocation? I dunno. Anyway, if you can reproduce it, please have a go, I'm at work and won't be able to do anything more in depth for some time. I could have sworn that I had some bounds checking in there at one point, but it doesn't seem to be in the latest version of the code. *shrug*. It should be both in cstring_enum() in enum.c and in DefineEnum() in typecmds.c. Cheers Tom ---------------------------(end of broadcast)--------------------------- TIP 4: Have you searched our list archives? http://archives.postgresql.org |
| ||||
| "Tom Dunstan" <pgsql@tomd.cc> writes: >> Looks like we need to check the length on type creation >> too. > It works for me (ie fails with an appropriate error) locally > on Linux FC6 x86-64. Perhaps this platform initializes > memory to zero on allocation? Sounds more like you're testing without asserts enabled; tut tut. regards, tom lane ---------------------------(end of broadcast)--------------------------- TIP 1: if posting/reading through Usenet, please send an appropriate subscribe-nomail command to majordomo@postgresql.org so that your message can get through to the mailing list cleanly |