David Fetter <david@fetter.org> writes:
> I haven't included the customary diffs. This points me to some of the
> many deficiencies of CVS, namely that I would need write access in
> order to have it create a diff,

Strange, it works fine for everyone else.

regards, tom lane

---------------------------(end of broadcast)---------------------------
TIP 7: You can help support the PostgreSQL project by donating at

http://www.postgresql.org/about/donate

Tom Lane wrote:
> David Fetter <david@fetter.org> writes:
>
>> I haven't included the customary diffs. This points me to some of the
>> many deficiencies of CVS, namely that I would need write access in
>> order to have it create a diff,
>>
>
> Strange, it works fine for everyone else.
>
>
>

Especially if you have cvsutils installed (can be found in many places
including fedora extras).

cheers

andrew

---------------------------(end of broadcast)---------------------------
TIP 9: In versions below 8.0, the planner will ignore your desire to
choose an index scan if your joining column's datatypes do not
match

David Fetter <david@fetter.org> writes:
> On Sun, May 13, 2007 at 07:04:44PM -0400, Andrew Dunstan wrote:
>> Tom Lane wrote:
>>> Strange, it works fine for everyone else.
>>
>> Especially if you have cvsutils installed (can be found in many
>> places including fedora extras).

> I didn't know about those, so I'll prepare a patch to the developer
> and documenter docs that mentions this utility

I dunno what cvsutils is, but I do know that plain old "cvs diff" works
fine whether you have commit privs or not. Rather than preparing a
patch to our docs, perhaps you should spend some time reading the CVS
docs.

regards, tom lane

---------------------------(end of broadcast)---------------------------
TIP 5: don't forget to increase your free space map settings

David Fetter wrote:
> cvs diff works just great until you want to add or remove a file
> without write permissions to the CVS repository, i.e. when you've
> checked out as anonymous.
>

I usually saved an untouched version of the tree to compare against, so
something like:

$ cvs diff -Nacr pgsql.orig pgsql

gives a complete patch including added/deleted files. It is a bit
primitive, but is pretty easy to do!

Cheers

Mark

---------------------------(end of broadcast)---------------------------
TIP 4: Have you searched our list archives?

http://archives.postgresql.org

On Sun, 2007-13-05 at 18:58 -0700, David Fetter wrote:
> cvs diff works just great until you want to add or remove a file
> without write permissions to the CVS repository, i.e. when you've
> checked out as anonymous.

Personally, I usually work against a checkout from a local mirror of the
CVS repository (which you can create via cvsup or rsync). With that
setup, "cvs add" and "cvs diff -N" work fine, since you can arrange for
write access to the local mirror.

(I'm always surprised to hear that anyone does a non-trivial amount of
work on Postgres without setting up a CVS mirror...)

-Neil



---------------------------(end of broadcast)---------------------------
TIP 6: explain analyze is your friend

"Tom Lane" <tgl@sss.pgh.pa.us> writes:

> David Fetter <david@fetter.org> writes:
>> I haven't included the customary diffs. This points me to some of the
>> many deficiencies of CVS, namely that I would need write access in
>> order to have it create a diff,
>
> Strange, it works fine for everyone else.

If you have rsh/ssh access to a CVS repository then you do in fact need write
access just to generate diffs. It is one of the annoyances of CVS but it
doesn't really matter for Postgres where we use pserver anonymous access.

Personally I find CVS so terribly slow for large trees like Postgres that it's
essential to use rsync to maintain a local CVS repository. That makes 'cvs
diff' remarkably fast.

--
Gregory Stark
EnterpriseDB http://www.enterprisedb.com


---------------------------(end of broadcast)---------------------------
TIP 5: don't forget to increase your free space map settings

Gregory Stark wrote:
> "Tom Lane" <tgl@sss.pgh.pa.us> writes:
>
>> David Fetter <david@fetter.org> writes:
>>> I haven't included the customary diffs. This points me to some of the
>>> many deficiencies of CVS, namely that I would need write access in
>>> order to have it create a diff,
>> Strange, it works fine for everyone else.
>
> If you have rsh/ssh access to a CVS repository then you do in fact need write
> access just to generate diffs. It is one of the annoyances of CVS but it
> doesn't really matter for Postgres where we use pserver anonymous access.

You need write-access to add files, even on anonymouse server. We often
get patches with new files as separate attachments because of that.

> Personally I find CVS so terribly slow for large trees like Postgres that it's
> essential to use rsync to maintain a local CVS repository. That makes 'cvs
> diff' remarkably fast.

Yeah, I've done that for a long time. It's by far the best way to work
with CVS, "cvs add" works, and you can do diffs, checkouts etc. offline.

--
Heikki Linnakangas
EnterpriseDB http://www.enterprisedb.com

---------------------------(end of broadcast)---------------------------
TIP 2: Don't 'kill -9' the postmaster

"Heikki Linnakangas" <heikki@enterprisedb.com> writes:

> You need write-access to add files, even on anonymouse server. We often get
> patches with new files as separate attachments because of that.

Oh quite right. I had forgotten but that was the original reason I switched to
using rsync. The alternative is to manually edit the Entries files to list the
new files.

--
Gregory Stark
EnterpriseDB http://www.enterprisedb.com


---------------------------(end of broadcast)---------------------------
TIP 3: Have you checked our extensive FAQ?

http://www.postgresql.org/docs/faq

Heikki Linnakangas wrote:
>
> You need write-access to add files, even on anonymouse server. We
> often get patches with new files as separate attachments because of that.
>
>

This is the part that cvsutils fakes for you (by hacking the local cvs
metadata files) so you don't need write access.

cheers

andrew

---------------------------(end of broadcast)---------------------------
TIP 4: Have you searched our list archives?

http://archives.postgresql.org

On Mon, 14 May 2007, Gregory Stark wrote:

> Personally I find CVS so terribly slow for large trees like Postgres that it's
> essential to use rsync to maintain a local CVS repository. That makes 'cvs
> diff' remarkably fast.

Having recently tried to get this to work right and not quite nailed it
down yet, I know it would be a help to new developers if someone using
this technique would write out a suggested setup/workflow for generating
patches this way. Right now the best instructions out there are those
that go with the buildfarm

http://pgfoundry.org/docman/view.php...Farm-HOWTO.txt

and those aren't quite focused right if the goal is to work on new patches
while keeping in sync with the repository.

--
* Greg Smith gsmith@gregsmith.com http://www.gregsmith.com Baltimore, MD

---------------------------(end of broadcast)---------------------------
TIP 9: In versions below 8.0, the planner will ignore your desire to
choose an index scan if your joining column's datatypes do not
match