This is a discussion on Re: [HACKERS] Error in from_char() for field 'D'? within the Pgsql Patches forums, part of the PostgreSQL category; --> Tom Lane wrote: > "Brendan Jurd" <direvus@gmail.com> writes: > > However, in from_char(), the reverse is not true. Looking ...
| |||||||
| FAQ | Members List | Calendar | Search | Today's Posts | Mark Forums Read |
| ||||
| Tom Lane wrote: > "Brendan Jurd" <direvus@gmail.com> writes: > > However, in from_char(), the reverse is not true. Looking at the code > > snippet above, the digit is scanned straight into tmfc->d unaltered > > (this value is later copied directly to tm->tm_wday circa line 3394). > > Unless I'm missing something, when converting to text, 'D' yields 1-7, > > but when converting back from text, 'D' expects 0-6. > > Although this does look like a bug, I'm not sure it matters, because > AFAICS there is no code path that will look at the value of tm_wday > while constructing a timestamp value from a struct tm. I'm inclined > not to risk messing with it just before RC1 unless a visible fault > can be demonstrated. Fixed in 8.3, patch attached. -- Bruce Momjian <bruce@momjian.us> http://momjian.us EnterpriseDB http://www.enterprisedb.com + If your life is a hard drive, Christ can be your backup. + ---------------------------(end of broadcast)--------------------------- TIP 9: In versions below 8.0, the planner will ignore your desire to choose an index scan if your joining column's datatypes do not match |