SEO
vBulletin Search Engine Optimization
| |||||||
![Re: [HACKERS] Multiline privileges in \z](http://unixadmintalk.com/iconimages/f47/re-hackers-multiline-privileges-z_ltr.gif)
| Register | FAQ | Members List | Calendar | Search | Today's Posts | Mark Forums Read |
04-19-2008, 06:28 AM
| ||||
| ||||
 Re: [HACKERS] Multiline privileges in \z "Brendan Jurd" <direvus@gmail.com> writes: > It occurred to me that psql's \z command could benefit from the > addition of some newlines. With any more than one grantee per object, > the output of \z rapidly becomes extremely wide, and very hard to > read. Seems like a good idea now that psql deals nicely with multiline output. The function names in the patch need schema-qualification in case pg_catalog is not first in the search path. regards, tom lane -- Sent via pgsql-patches mailing list (pgsql-patches@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-patches      |
|
05-05-2008, 05:53 AM
| |||
| |||
| Re: [HACKERS] Multiline privileges in \z Brendan Jurd wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > On Fri, Apr 18, 2008 at 2:37 AM, Tom Lane wrote: > >> The function names in the patch need schema-qualification in case >> pg_catalog is not first in the search path. >> >> > > Ah, yes. I should have seen that. Thanks Tom. > > New version attached with schema-qualification. > Wouldn't this expression: pg_catalog.array_to_string(c.relacl, chr(10)) be better expressed as pg_catalog.array_to_string(c.relacl, E'\n') ? Quoted inside a C literal, the backslash would have to be doubled, of course. cheers andrew -- Sent via pgsql-patches mailing list (pgsql-patches@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-patches |
|
05-05-2008, 05:53 AM
| |||
| |||
| Re: [HACKERS] Multiline privileges in \z Andrew Dunstan <andrew@dunslane.net> writes: > Wouldn't this expression: > pg_catalog.array_to_string(c.relacl, chr(10)) > be better expressed as > pg_catalog.array_to_string(c.relacl, E'\n') +1 ... it's minor, but knowing that ASCII LF is 10 is probably not wired into too many people's brains anymore. (Besides, some of us remember it as octal 12, anyway...) regards, tom lane -- Sent via pgsql-patches mailing list (pgsql-patches@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-patches |
|
05-05-2008, 05:53 AM
| |||
| |||
| Re: [HACKERS] Multiline privileges in \z -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On Sun, May 4, 2008 at 10:55 AM, Tom Lane wrote: > Andrew Dunstan writes: > > Wouldn't this expression: > > pg_catalog.array_to_string(c.relacl, chr(10)) > > be better expressed as > > pg_catalog.array_to_string(c.relacl, E'\n') > > +1 ... it's minor, but knowing that ASCII LF is 10 is probably not > wired into too many people's brains anymore. (Besides, some of us > remember it as octal 12, anyway...) > Fair enough. I just wanted a non-messy way of saying "1 newline, please", and I wasn't too sure whether backslash escapes were considered kosher for internal queries. But you're right, readability is important. No objections to using the escape syntax. Please note that I used chr(10) in my \du attributes patch as well. Cheers, BJ -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.7 (GNU/Linux) Comment: http://getfiregpg.org iD8DBQFIHjNA5YBsbHkuyV0RAuNSAJ0ZDLxhHaPj4CBsBCILnx Hy+5Jf5ACfQHMH 4XZxczc+YEow3AFdayn9fGs= =+TSV -----END PGP SIGNATURE----- -- Sent via pgsql-patches mailing list (pgsql-patches@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-patches |
|
05-05-2008, 05:53 AM
| ||||
| ||||
| Re: [HACKERS] Multiline privileges in \z Brendan Jurd wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > On Fri, Apr 18, 2008 at 2:37 AM, Tom Lane wrote: > >> The function names in the patch need schema-qualification in case >> pg_catalog is not first in the search path. >> >> > > Ah, yes. I should have seen that. Thanks Tom. > > New version attached with schema-qualification. > > > Committed with slight editorialization and a consequent docs change. cheers andrew -- Sent via pgsql-patches mailing list (pgsql-patches@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-patches |
Linear Mode
