SEO
vBulletin Search Engine Optimization
| |||||||
![Re: [HACKERS] Problem with ControlFileData structure being ABI dependent](http://unixadmintalk.com/iconimages/f47/re-hackers-problem-controlfiledata-structure-being-abi-dependent_ltr.gif)
| Register | FAQ | Members List | Calendar | Search | Today's Posts | Mark Forums Read |
04-19-2008, 06:24 AM
| ||||
| ||||
 Re: [HACKERS] Problem with ControlFileData structure being ABI dependent Dave Page wrote: > Tom Lane wrote: >> Dave Page <dpage@postgresql.org> writes: >>> Gregory Stark wrote: >>>> An alternative is leaving it in the project file but putting >>>> something like >>>> this in c.h: >> >> Put it in win32.h, please. c.h shouldn't get cluttered with >> platform-specific kluges when there's no need for it. >> >> Is there a good reason not to just #define _USE_32BIT_TIME_T in win32.h? > > Yeah, the fact that addons may then end up partially compiled with and > partially without it being defined. It we just have it error as Greg > suggested, then it will force the authors to define it themselves, and > if they get that wrong it's their fault not ours. Patch attached. /D ---------------------------(end of broadcast)--------------------------- TIP 3: Have you checked our extensive FAQ? http://www.postgresql.org/docs/faq      |
|
04-19-2008, 06:24 AM
| ||||
| ||||
| Re: [HACKERS] Problem with ControlFileData structure being ABI depe ndent On Mon, Dec 10, 2007 at 09:56:39AM +0000, Dave Page wrote: > Dave Page wrote: > > Tom Lane wrote: > >> Dave Page <dpage@postgresql.org> writes: > >>> Gregory Stark wrote: > >>>> An alternative is leaving it in the project file but putting > >>>> something like > >>>> this in c.h: > >> > >> Put it in win32.h, please. c.h shouldn't get cluttered with > >> platform-specific kluges when there's no need for it. > >> > >> Is there a good reason not to just #define _USE_32BIT_TIME_T in win32.h? > > > > Yeah, the fact that addons may then end up partially compiled with and > > partially without it being defined. It we just have it error as Greg > > suggested, then it will force the authors to define it themselves, and > > if they get that wrong it's their fault not ours. > > Patch attached. Applide with two tiny modifications - the missing quote taht you mentioned, and changed the #ifdef to only affect MSVC and not mingw. //Magnus ---------------------------(end of broadcast)--------------------------- TIP 5: don't forget to increase your free space map settings |
 |
« SB NOTICE: eBay Registration Suspension - Shill Bidding
|
Proposed patch to avoid translation risks in psql's \d commands »
| Thread Tools | |
| Display Modes | |
Linear Mode
|
|
All times are GMT. The time now is 11:35 AM.
