SEO

#1 (**permalink**) 04-18-2008, 09:15 AM

Bruce Momjian <bruce@momjian.us> writes:
> Martijn van Oosterhout wrote:
>> I don't know enough about the relevent tool to know if they actually
>> generate a warning about whether they need to be rerun. In any case it
>> seems a much better approach to simply run it again when needed rather
>> than printing a warning.

> The problem is that there is no indication from the make (no warning)
> that you have to rerun, and it isn't something people are used to doing
> like with latex.

If the objective is to make it safe against people who do not understand
how the tools work, then I still complain that this method is
insufficient. All you are testing is whether an index was generated,
not whether it was correct (ie, up to date). A valid test would be
along the lines of comparing the pre-run and post-run copies of the
index data to see if they're the same.

Perhaps even more to the point, what makes you think that someone will
notice the warning? If the docs build is one step in an automated build
process, this seems unlikely.

regards, tom lane

---------------------------(end of broadcast)---------------------------
TIP 9: In versions below 8.0, the planner will ignore your desire to
choose an index scan if your joining column's datatypes do not
match

#2 (**permalink**) 04-18-2008, 09:16 AM

Tom Lane wrote:
> Perhaps even more to the point, what makes you think that someone
> will notice the warning? If the docs build is one step in an
> automated build process, this seems unlikely.

Taking a closer look, it's pretty much guaranteed that no one will see
them, because the targets they are attached to are intermediate,
normally followed by latex runs.
--
Peter Eisentraut
http://developer.postgresql.org/~petere/

---------------------------(end of broadcast)---------------------------
TIP 1: if posting/reading through Usenet, please send an appropriate
subscribe-nomail command to majordomo@postgresql.org so that your
message can get through to the mailing list cleanly

#3 (**permalink**) 04-18-2008, 09:16 AM

Peter Eisentraut <peter_e@gmx.net> writes:
> Tom Lane wrote:
>> Perhaps even more to the point, what makes you think that someone
>> will notice the warning? If the docs build is one step in an
>> automated build process, this seems unlikely.

> Taking a closer look, it's pretty much guaranteed that no one will see
> them, because the targets they are attached to are intermediate,
> normally followed by latex runs.

If we think this is a problem, ISTM the correct answer is to just force
a repeat jade run when doing "make all". The only objection to that
AFAICS is that when you're doing docs work and only need a draft to
look at, you'd rather it not run twice. But perhaps we could address
that by providing a separate target, "make draft" say, that runs jade
but once.

regards, tom lane

---------------------------(end of broadcast)---------------------------
TIP 4: Have you searched our list archives?

http://archives.postgresql.org

#4 (**permalink**) 04-18-2008, 09:16 AM

On Sun, 7 Jan 2007, Tom Lane wrote:

> Peter Eisentraut <peter_e@gmx.net> writes:
> > Tom Lane wrote:
> >> Perhaps even more to the point, what makes you think that someone
> >> will notice the warning? If the docs build is one step in an
> >> automated build process, this seems unlikely.
>
> > Taking a closer look, it's pretty much guaranteed that no one will see
> > them, because the targets they are attached to are intermediate,
> > normally followed by latex runs.
>
> If we think this is a problem, ISTM the correct answer is to just force
> a repeat jade run when doing "make all". The only objection to that
> AFAICS is that when you're doing docs work and only need a draft to
> look at, you'd rather it not run twice. But perhaps we could address
> that by providing a separate target, "make draft" say, that runs jade
> but once.

That's a nice approach. Those working on the docs will know about the
draft target and those just wanting to build the docs for publication will
get the result.

Gavin

---------------------------(end of broadcast)---------------------------
TIP 5: don't forget to increase your free space map settings

Thread Tools
Show Printable Version Email this Page
Display Modes
Linear Mode Switch to Hybrid Mode Switch to Threaded Mode

SEO

Re: [HACKERS] SGML index build fix