Unix Technical Forum

Re: re-enable MSVC builds

This is a discussion on Re: re-enable MSVC builds within the Pgsql Patches forums, part of the PostgreSQL category; --> > > The attached patch allows MSCV builds to complete. > > Applied. > > (I wonder whether the ...


Go Back   Unix Technical Forum > Database Server Software > PostgreSQL > Pgsql Patches

FAQ Members List Calendar Search Today's Posts Mark Forums Read
  #1 (permalink)  
Old 04-17-2008, 10:57 PM
Magnus Hagander
 
Posts: n/a
Default Re: re-enable MSVC builds

> > The attached patch allows MSCV builds to complete.
>
> Applied.
>
> (I wonder whether the Borland build still works...)


I'm sure it still eneds the shell32 linking. The suorce part should be
the same - AFAIK they ship the MS headers. But I don't have a way to
test it, so...


> > The warnings still shown (see recent -hackers email) are

> identical to
> > those that were present in RC2, so they are not the

> products of recent
> > homedir changes.

>
> With the possible exception of the mkdir warning, these seem
> cosmetic and not worth worrying about at this stage of the
> release cycle.


Definitly. There have been cosmetic warnings in the win32 build ever
since it was created.

//Magnus

---------------------------(end of broadcast)---------------------------
TIP 6: Have you searched our list archives?

http://archives.postgresql.org

Digg this Post!Add Post to del.icio.usBookmark Post in TechnoratiFurl this Post!
Reply With Quote
  #2 (permalink)  
Old 04-17-2008, 10:57 PM
Tom Lane
 
Posts: n/a
Default Re: re-enable MSVC builds

Andrew Dunstan <andrew@dunslane.net> writes:
> Magnus Hagander wrote:
>> I'm sure it still eneds the shell32 linking.


> I don't see where to put it in the bcc.mak file anyway.


Yeah, I looked in bcc32.mak and didn't see any reference to the other
*32.dll files that win32.mak references. So either Borland does not
need any of them, or the Borland build has been broken for awhile.

If someone steps up to fix it, great, otherwise it's on the path to
extinction...

regards, tom lane

---------------------------(end of broadcast)---------------------------
TIP 2: you can get off all lists at once with the unregister command
(send "unregister YourEmailAddressHere" to majordomo@postgresql.org)

Digg this Post!Add Post to del.icio.usBookmark Post in TechnoratiFurl this Post!
Reply With Quote
  #3 (permalink)  
Old 04-17-2008, 10:57 PM
Andrew Dunstan
 
Posts: n/a
Default Re: re-enable MSVC builds



Magnus Hagander wrote:

>>>The attached patch allows MSCV builds to complete.
>>>
>>>

>>Applied.
>>
>>(I wonder whether the Borland build still works...)
>>
>>

>
>I'm sure it still eneds the shell32 linking. The suorce part should be
>the same - AFAIK they ship the MS headers. But I don't have a way to
>test it, so...
>
>
>
>
>


Me either, and I don't have time to acquire/test before release. I don't
see where to put it in the bcc.mak file anyway. So, either it's not
broken, or it is broken and will stay that way, or it is broken and
somebody else will step in *real* quick to fix it :-) I am not betting
on this last.

cheers

andrew

---------------------------(end of broadcast)---------------------------
TIP 5: Have you checked our extensive FAQ?

http://www.postgresql.org/docs/faqs/FAQ.html

Digg this Post!Add Post to del.icio.usBookmark Post in TechnoratiFurl this Post!
Reply With Quote
Reply


Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

vB code is On
Smilies are On
[IMG] code is On
HTML code is Off
Trackbacks are On
Pingbacks are On
Refbacks are On
Forum Jump


All times are GMT. The time now is 03:37 PM.


Powered by vBulletin® Version 3.6.5
Copyright ©2000 - 2008, Jelsoft Enterprises Ltd.
SEO by vBSEO 3.2.0
www.UnixAdminTalk.com