Kris Jurka <books@ejurka.com> writes:
> The attached patch removes this warning:
> encnames.c:511: warning: passing argument 1 of 'clean_encoding_name'
> discards qualifiers from pointer target type

Applied, but I've not seen that warning myself ... what compiler are
you using exactly?

regards, tom lane

---------------------------(end of broadcast)---------------------------
TIP 7: You can help support the PostgreSQL project by donating at

http://www.postgresql.org/about/donate

On Mon, 16 Apr 2007, Tom Lane wrote:

> Kris Jurka <books@ejurka.com> writes:
>> The attached patch removes this warning:
>> encnames.c:511: warning: passing argument 1 of 'clean_encoding_name'
>> discards qualifiers from pointer target type
>
> Applied, but I've not seen that warning myself ... what compiler are
> you using exactly?
>

I was testing a gcc 4.3 snapshot from 3/26/07. It also complains

hba.c:1199: warning: array subscript is below array bounds

Which looks pretty bogus to me. And then the following which may be
valid, but wasn't something I was concerned about at this time.

tuplesort.c: In function 'comparetup_heap':
tuplesort.c:2124: warning: inlining failed in call to 'myFunctionCall2':
--param large-stack-frame-growth limit reached
tuplesort.c:2175: warning: called from here
tuplesort.c:2124: warning: inlining failed in call to 'myFunctionCall2':
--param large-stack-frame-growth limit reached
tuplesort.c:2175: warning: called from here
tuplesort.c: In function 'ApplySortFunction':
tuplesort.c:2124: warning: inlining failed in call to 'myFunctionCall2':
--param large-stack-frame-growth limit reached
tuplesort.c:2175: warning: called from here
tuplesort.c: In function 'comparetup_datum':
tuplesort.c:2124: warning: inlining failed in call to 'myFunctionCall2':
--param large-stack-frame-growth limit reached
tuplesort.c:2175: warning: called from here
tuplesort.c: In function 'comparetup_index':
tuplesort.c:2124: warning: inlining failed in call to 'myFunctionCall2':
--param large-stack-frame-growth limit reached
tuplesort.c:2175: warning: called from here
tuplesort.c:2124: warning: inlining failed in call to 'myFunctionCall2':
--param large-stack-frame-growth limit reached
tuplesort.c:2175: warning: called from here

Kris Jurka


---------------------------(end of broadcast)---------------------------
TIP 5: don't forget to increase your free space map settings

Kris Jurka <books@ejurka.com> writes:
> I was testing a gcc 4.3 snapshot from 3/26/07. It also complains
> hba.c:1199: warning: array subscript is below array bounds
> Which looks pretty bogus to me.

I agree.

> And then the following which may be
> valid, but wasn't something I was concerned about at this time.

> tuplesort.c: In function 'comparetup_heap':
> tuplesort.c:2124: warning: inlining failed in call to 'myFunctionCall2':
> --param large-stack-frame-growth limit reached
> tuplesort.c:2175: warning: called from here

We've got -Winline turned on mainly as a means of finding out whether
inlining happens or not. I think it's OK to ignore this unless it
happens all over the place.

regards, tom lane

---------------------------(end of broadcast)---------------------------
TIP 7: You can help support the PostgreSQL project by donating at

http://www.postgresql.org/about/donate

On Mon, Apr 16, 2007 at 02:51:55PM -0400, Tom Lane wrote:
> Kris Jurka <books@ejurka.com> writes:
> > The attached patch removes this warning:
> > encnames.c:511: warning: passing argument 1 of 'clean_encoding_name'
> > discards qualifiers from pointer target type
>
> Applied, but I've not seen that warning myself ... what compiler are
> you using exactly?

In general these warning turn up with either -Wwrite-strings (which find
"string" embedded in the source code with are assigned to char*
variables (or given as parameters). Or using -Wcast-qual for 'general'
discarding a const qualifier.

Regards,
Stefan


---------------------------(end of broadcast)---------------------------
TIP 1: if posting/reading through Usenet, please send an appropriate
subscribe-nomail command to majordomo@postgresql.org so that your
message can get through to the mailing list cleanly