SEO

#1 (**permalink**) 04-18-2008, 10:01 AM

Your patch has been added to the PostgreSQL unapplied patches list at:

http://momjian.postgresql.org/cgi-bin/pgpatches

It will be applied as soon as one of the PostgreSQL committers reviews
and approves it.

---------------------------------------------------------------------------

Jaime Casanova wrote:
> On 5/3/07, Bruce Momjian <bruce@momjian.us> wrote:
> >
> > Your patch has been added to the PostgreSQL unapplied patches list at:
> >
>
> This is an updated version of the patch.
>
> Tom objections:
> - fd.c is too low level for calling code from commands/tablespace.c.
> This was fixed adding a second parameter to BufFileCreateTemp() to send
> the tblspcOid (this function is called from executor/nodeHashJoin.c,
> utils/sort/logtape.c and utils/sort/tuplestore.c). Are these places ok?
>
> - RemovePgTempFilesInDir() has no support for removing temp files from
> strange locations.
> Per Tom suggestion temp files are now created in: base/pgsql_tmp and
> pg_tblspc/$oid_tblspc/pgsql_tmp. So i just refactor RemovePgTempFiles()
> to call RemovePgTempFilesInDir() with base and pg_tblspc/$oid_tblspc's
> pgsql_tmp
>
> Other changes in code:
> fd.c:
> functions make_database_relative() and FileNameOpenFile() were marked
> as NOT_USED. objections to simply delete them?
> also added OpenTempFileInTblspc() to create the tempfilepath and call
> to PathNameOpenFile()
> buffile.c:
> also added a new tblspcOid field to BufFile struct to use it in extendBufFile()
>
>
> Problems:
> While the patch passes all the regression tests i still have a problem
> when doin this:
>
> sgerp=# set temp_tablespaces = '';
> ERROR: tablespace "" does not exist
>
> note that setting temp_tablespaces = '' from postgresql.conf works well.
>
> maybe this is silly but it's too late for me... i will keep trying
> tomorrow unless someone else has fixed it.
>
> comments?
>
> --
> regards,
> Jaime Casanova
>
> "Programming today is a race between software engineers striving to
> build bigger and better idiot-proof programs and the universe trying
> to produce bigger and better idiots.
> So far, the universe is winning."
> Richard Cook

[ Attachment, skipping... ]

>
> ---------------------------(end of broadcast)---------------------------
> TIP 4: Have you searched our list archives?
>
> http://archives.postgresql.org

--
Bruce Momjian <bruce@momjian.us> http://momjian.us
EnterpriseDB http://www.enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

---------------------------(end of broadcast)---------------------------
TIP 2: Don't 'kill -9' the postmaster

#2 (**permalink**) 04-18-2008, 10:01 AM

Am Samstag, 5. Mai 2007 16:40 schrieb Jaime Casanova:
> On 5/5/07, Bruce Momjian <bruce@momjian.us> wrote:
> > Your patch has been added to the PostgreSQL unapplied patches list at:
>
> This is final version of the patch (i hope), at least it fixes the
> problem i had yesterday.

What I have been missing all along in these patches is an explanation for what
it means to list multiple temporary tablespaces. Are they used in order, or
the first one that exists, or what?

--
Peter Eisentraut
http://developer.postgresql.org/~petere/

---------------------------(end of broadcast)---------------------------
TIP 5: don't forget to increase your free space map settings

#3 (**permalink**) 04-18-2008, 10:01 AM

On 5/8/07, Peter Eisentraut <peter_e@gmx.net> wrote:
> Am Samstag, 5. Mai 2007 16:40 schrieb Jaime Casanova:
> > On 5/5/07, Bruce Momjian <bruce@momjian.us> wrote:
> > > Your patch has been added to the PostgreSQL unapplied patches list at:
> >
> > This is final version of the patch (i hope), at least it fixes the
> > problem i had yesterday.
>
> What I have been missing all along in these patches is an explanation for what
> it means to list multiple temporary tablespaces. Are they used in order, or
> the first one that exists, or what?
>

http://archives.postgresql.org/pgsql...1/msg00531.php
http://archives.postgresql.org/pgsql...1/msg00282.php

in src/backend/commands/tablespace.c:assign_temp_tablespaces():

/*
* Select the first tablespace to use
*/
Assert(num_temp_tablespaces >= 0);
if (num_temp_tablespaces != 0)
next_temp_tablespace = MyProcPid % num_temp_tablespaces;

--
regards,
Jaime Casanova

"Programming today is a race between software engineers striving to
build bigger and better idiot-proof programs and the universe trying
to produce bigger and better idiots.
So far, the universe is winning."
Richard Cook

---------------------------(end of broadcast)---------------------------
TIP 6: explain analyze is your friend

#4 (**permalink**) 04-18-2008, 10:01 AM

Am Mittwoch, 9. Mai 2007 02:21 schrieb Jaime Casanova:
> > What I have been missing all along in these patches is an explanation for
> > what it means to list multiple temporary tablespaces. Are they used in
> > order, or the first one that exists, or what?
>
> http://archives.postgresql.org/pgsql...1/msg00531.php
> http://archives.postgresql.org/pgsql...1/msg00282.php

Those are discussions of possible ideas, not an acceptable documentation of
this feature.

> in src/backend/commands/tablespace.c:assign_temp_tablespaces():

That also isn't an acceptable place to put feature documentation.

> /*
> * Select the first tablespace to use
> */
> Assert(num_temp_tablespaces >= 0);
> if (num_temp_tablespaces != 0)
> next_temp_tablespace = MyProcPid % num_temp_tablespaces;

What does this mean? Is there code that selects the second tablespace to use?

--
Peter Eisentraut
http://developer.postgresql.org/~petere/

---------------------------(end of broadcast)---------------------------
TIP 6: explain analyze is your friend

Thread Tools
Show Printable Version Email this Page
Display Modes
Linear Mode Switch to Hybrid Mode Switch to Threaded Mode

SEO

Re: [WIP] GUC for temp_tablespaces