SEO

#1 (**permalink**) 04-17-2008, 11:02 PM

This patch changes the input routines for float4, float8 and oid to
reject empty strings (rather than treating them as "0"). In 8.0 we issue
a warning about this behavior and indicate that the input will not be
accepted by a future release, so it seems reasonable to disallow the
input in 8.1. The patch also updates the regression tests.

Barring any objections, I'll apply this to HEAD tomorrow.

-Neil

---------------------------(end of broadcast)---------------------------
TIP 5: Have you checked our extensive FAQ?

http://www.postgresql.org/docs/faq

#2 (**permalink**) 04-17-2008, 11:02 PM

Neil Conway <neilc@samurai.com> writes:
> On Thu, 2005-02-10 at 20:53 -0500, Tom Lane wrote:
>> If you're going to add regression tests, how about testing the case of a
>> non-empty-but-all-whitespace string?

> AFAICS that is already tested for.

[ looks again... ] Doh. Maybe you should put these tests next to those
then...

regards, tom lane

---------------------------(end of broadcast)---------------------------
TIP 1: subscribe and unsubscribe commands go to majordomo@postgresql.org

#3 (**permalink**) 04-17-2008, 11:02 PM

On Thu, 2005-02-10 at 20:53 -0500, Tom Lane wrote:
> If you're going to add regression tests, how about testing the case of a
> non-empty-but-all-whitespace string?

AFAICS that is already tested for.

-Neil

---------------------------(end of broadcast)---------------------------
TIP 3: if posting/reading through Usenet, please send an appropriate
subscribe-nomail command to majordomo@postgresql.org so that your
message can get through to the mailing list cleanly

#4 (**permalink**) 04-17-2008, 11:02 PM

Neil Conway <neilc@samurai.com> writes:
> This patch changes the input routines for float4, float8 and oid to
> reject empty strings (rather than treating them as "0"). In 8.0 we issue
> a warning about this behavior and indicate that the input will not be
> accepted by a future release, so it seems reasonable to disallow the
> input in 8.1. The patch also updates the regression tests.

If you're going to add regression tests, how about testing the case of a
non-empty-but-all-whitespace string?

regards, tom lane

---------------------------(end of broadcast)---------------------------
TIP 1: subscribe and unsubscribe commands go to majordomo@postgresql.org

Thread Tools
Show Printable Version Email this Page
Display Modes
Linear Mode Switch to Hybrid Mode Switch to Threaded Mode

SEO

reject empty string in float[48], oid