SEO

The attached patch warns users when they create documentation output
that has no index, and suggests re-running 'gmake'.

--
Bruce Momjian bruce@momjian.us
EnterpriseDB http://www.enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +


---------------------------(end of broadcast)---------------------------
TIP 3: Have you checked our extensive FAQ?

http://www.postgresql.org/docs/faq

Bruce Momjian <bruce@momjian.us> writes:
> The attached patch warns users when they create documentation output
> that has no index, and suggests re-running 'gmake'.

This is just useless noise. If it could tell the difference between an
up-to-date index and a not-up-to-date one, there might be some value
to it ... but as-is I think it's just getting in the user's face.
Everyone using these tools knows about the two-pass behavior.

I just got done reading an interesting comparison of MS Vista versus
Mac OS X:
http://www.informationweek.com/news/...leID=196800670
The guy's very first complaint about Vista is how it demands your
attention constantly with trivial warning messages. This seems in much
the same vein.

regards, tom lane

---------------------------(end of broadcast)---------------------------
TIP 4: Have you searched our list archives?

http://archives.postgresql.org

Tom Lane wrote:
> Bruce Momjian <bruce@momjian.us> writes:
> > The attached patch warns users when they create documentation output
> > that has no index, and suggests re-running 'gmake'.
>
> This is just useless noise. If it could tell the difference between an
> up-to-date index and a not-up-to-date one, there might be some value
> to it ... but as-is I think it's just getting in the user's face.
> Everyone using these tools knows about the two-pass behavior.

I certainly did not, and it warns only when an invalid HTML.index is
used.

--
Bruce Momjian bruce@momjian.us
EnterpriseDB http://www.enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

---------------------------(end of broadcast)---------------------------
TIP 1: if posting/reading through Usenet, please send an appropriate
subscribe-nomail command to majordomo@postgresql.org so that your
message can get through to the mailing list cleanly

Bruce Momjian wrote:
> Tom Lane wrote:
> > Bruce Momjian <bruce@momjian.us> writes:
> > > The attached patch warns users when they create documentation output
> > > that has no index, and suggests re-running 'gmake'.
> >
> > This is just useless noise. If it could tell the difference between an
> > up-to-date index and a not-up-to-date one, there might be some value
> > to it ... but as-is I think it's just getting in the user's face.
> > Everyone using these tools knows about the two-pass behavior.
>
> I certainly did not, and it warns only when an invalid HTML.index is
> used.

And the people creating our PDFs didn't know because we often have to
update the web site with valid ones that have indexes.

--
Bruce Momjian bruce@momjian.us
EnterpriseDB http://www.enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

---------------------------(end of broadcast)---------------------------
TIP 6: explain analyze is your friend

On Sat, 2007-01-06 at 23:38 -0500, Tom Lane wrote:
> Bruce Momjian <bruce@momjian.us> writes:
> > The attached patch warns users when they create documentation output
> > that has no index, and suggests re-running 'gmake'.
>
> This is just useless noise. If it could tell the difference between an
> up-to-date index and a not-up-to-date one, there might be some value
> to it ... but as-is I think it's just getting in the user's face.
> Everyone using these tools knows about the two-pass behavior.

No, not everyone knows. In fact I would argue that most do not know. It
isn't intuitive to the process. You *expect* that an index will be made.

Joshua D. Drake

--

=== The PostgreSQL Company: Command Prompt, Inc. ===
Sales/Support: +1.503.667.4564 || 24x7/Emergency: +1.800.492.2240
Providing the most comprehensive PostgreSQL solutions since 1997
http://www.commandprompt.com/

Donate to the PostgreSQL Project: http://www.postgresql.org/about/donate




---------------------------(end of broadcast)---------------------------
TIP 5: don't forget to increase your free space map settings

Joshua D. Drake wrote:
> On Sat, 2007-01-06 at 23:38 -0500, Tom Lane wrote:
> > Bruce Momjian <bruce@momjian.us> writes:
> > > The attached patch warns users when they create documentation output
> > > that has no index, and suggests re-running 'gmake'.
> >
> > This is just useless noise. If it could tell the difference between an
> > up-to-date index and a not-up-to-date one, there might be some value
> > to it ... but as-is I think it's just getting in the user's face.
> > Everyone using these tools knows about the two-pass behavior.
>
> No, not everyone knows. In fact I would argue that most do not know. It
> isn't intuitive to the process. You *expect* that an index will be made.

The idea for the warning message actually came from Peter.

--
Bruce Momjian bruce@momjian.us
EnterpriseDB http://www.enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

---------------------------(end of broadcast)---------------------------
TIP 4: Have you searched our list archives?

http://archives.postgresql.org

Bruce Momjian wrote:
> The attached patch warns users when they create documentation output
> that has no index, and suggests re-running 'gmake'.

> ! # for some reason $wildcard expands too early, so we use 'test'

$wildcard is expanded whenever you tell it to. What did you write?

> ! @test -f bookindex.valid || echo "Run 'gmake' again to generate output with a proper index"

The proper command to run is $(MAKE).

> !

There is a redundant tab on that line.

> + @test -f bookindex.valid || echo "Run 'gmake' again to generate output with a proper index"

Probably better to capture that in a variable instead of copying it half a dozen times.

> -e '1a\' -e '<!DOCTYPE book PUBLIC "-//OASIS//DTD DocBook XML V4.2//EN" "http://www.oasis-open.org/docbook/xml/4.2/docbookx.dtd">' \
> >$@
> # ' hello Emacs
> + @test -f bookindex.valid || echo "Run 'gmake' again to generate output with a proper index"

When converting to XML, you probably don't want an index because it will
be built differently by the XSLT toolchain. It's not clear what we want
anyway.

--
Peter Eisentraut
http://developer.postgresql.org/~petere/

---------------------------(end of broadcast)---------------------------
TIP 5: don't forget to increase your free space map settings

On Sun, Jan 07, 2007 at 12:42:06AM -0500, Bruce Momjian wrote:
> Joshua D. Drake wrote:
> > On Sat, 2007-01-06 at 23:38 -0500, Tom Lane wrote:
> > > Everyone using these tools knows about the two-pass behavior.
> >
> > No, not everyone knows. In fact I would argue that most do not know. It
> > isn't intuitive to the process. You *expect* that an index will be made.
>
> The idea for the warning message actually came from Peter.

FWIW, I have this problem with LaTeX also, which needs multiple passes
occasionally to fix cross-references and idexes and stuff. The solution
I have in the makefile is a fragment like the following:

while egrep -q "^LaTeX Warning:.*Rerun to" logfile ; do
rm logfile
latex taxfile
done

I don't know enough about the relevent tool to know if they actually
generate a warning about whether they need to be rerun. In any case it
seems a much better approach to simply run it again when needed rather
than printing a warning.

Have a nice day,
--
Martijn van Oosterhout <kleptog@svana.org> http://svana.org/kleptog/
> From each according to his ability. To each according to his ability to litigate.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)

iD8DBQFFoNf4IB7bNG8LQkwRAlCaAJ9lmu335kb96EWNXWYptG qjO0XmvQCbBAmJ
WmuXTe46XEBCdRHcZdTuN7E=
=rkQP
-----END PGP SIGNATURE-----

Peter Eisentraut wrote:
> Bruce Momjian wrote:
> > The attached patch warns users when they create documentation output
> > that has no index, and suggests re-running 'gmake'.
>
> > ! # for some reason $wildcard expands too early, so we use 'test'
>
> $wildcard is expanded whenever you tell it to. What did you write?

I wrote:

ifeq (,$(wildcard bookindex.valid))
echo "Run 'gmake' again to generate output with a proper index"
endif

but that warns on the first _two_ runs, meaning it expanded at the time
the rule started, not at the time it hit that line.

> > ! @test -f bookindex.valid || echo "Run 'gmake' again to generate output with a proper index"
>
> The proper command to run is $(MAKE).

OK, updated.

>
> > !
>
> There is a redundant tab on that line.

OK, removed.

>
> > + @test -f bookindex.valid || echo "Run 'gmake' again to generate output with a proper index"
>
> Probably better to capture that in a variable instead of copying it half a dozen times.
>
> > -e '1a\' -e '<!DOCTYPE book PUBLIC "-//OASIS//DTD DocBook XML V4.2//EN" "http://www.oasis-open.org/docbook/xml/4.2/docbookx.dtd">' \
> > >$@
> > # ' hello Emacs
> > + @test -f bookindex.valid || echo "Run 'gmake' again to generate output with a proper index"
>
> When converting to XML, you probably don't want an index because it will
> be built differently by the XSLT toolchain. It's not clear what we want
> anyway.

OK, removed.

--
Bruce Momjian bruce@momjian.us
EnterpriseDB http://www.enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

---------------------------(end of broadcast)---------------------------
TIP 9: In versions below 8.0, the planner will ignore your desire to
choose an index scan if your joining column's datatypes do not
match

Bruce Momjian wrote:
> I wrote:
>
> ifeq (,$(wildcard bookindex.valid))
> echo "Run 'gmake' again to generate output with a proper index"
> endif
>
> but that warns on the first _two_ runs, meaning it expanded at the
> time the rule started, not at the time it hit that line.

This expands at the time the makefile is read. You may get it to work
with

target:
$(if $(wildcard blah), this, that)

The following may be helpful:
http://www.gnu.org/software/make/man...ding-Makefiles

--
Peter Eisentraut
http://developer.postgresql.org/~petere/

---------------------------(end of broadcast)---------------------------
TIP 5: don't forget to increase your free space map settings